Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented May 3, 2019

Based on a discussion with @andrewseguin.

Adds the distance that the user has dragged in the ended, moved and drop events. This makes cases like resize handles to be implemented more conveniently.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label May 3, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 3, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that this is really a feat and should be minor

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 8, 2019
@crisbeto crisbeto changed the title refactor(drag-drop): include dragged distance in events feat(drag-drop): include dragged distance in events May 8, 2019
Adds the distance that the user has dragged in the `ended`, `moved` and `drop` events. This makes cases like resize handles to be implemented more conveniently.
@crisbeto crisbeto force-pushed the drag-drop-distance branch from 50a0a81 to 6d54d7f Compare May 8, 2019 23:52
@jelbourn jelbourn merged commit 35a045c into angular:master May 13, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
Adds the distance that the user has dragged in the `ended`, `moved` and `drop` events. This makes cases like resize handles to be implemented more conveniently.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants