fix(drag-drop): don't allow user to move item into container that isn't connected to current one by passing it over an intermediate one that is #15660
Conversation
…'t connected to current one by passing it over an intermediate one that is In a setup like `Container 1 <-> Container 2 <-> Container 3` the user shouldn't be allowed to move items between containers 1 and 3, because they're not connected. This is currently possible if the user passes it through container 2 first. These changes rework the logic so that this is no longer possible. Fixes angular#15191.
googlebot
added
the
cla: yes
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
This is one the the funnier bugs I've seen.
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
…'t connected to current one by passing it over an intermediate one that is (angular#15660) In a setup like `Container 1 <-> Container 2 <-> Container 3` the user shouldn't be allowed to move items between containers 1 and 3, because they're not connected. This is currently possible if the user passes it through container 2 first. These changes rework the logic so that this is no longer possible. Fixes angular#15191.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
In a setup like
Container 1 <-> Container 2 <-> Container 3the user shouldn't be allowed to move items between containers 1 and 3, because they're not connected. This is currently possible if the user passes it through container 2 first. These changes rework the logic so that this is no longer possible.Fixes #15191.