refactor(snack-bar): rework to account for ivy #15537

crisbeto · 2019-03-19T16:21:44Z

Ivy equivalent of #15536.

Reworks the snack bar to account for a breaking change in Ivy.

See scripts/ivy/README.md for instructions.

This makes the unit tests runnable on the ivy-2019 branch by making the following changes: * Use the unminified umd bundles. The minified bundles fail due to some yet indeterminate bug. * Update the install script to be platform independent (formerly only worked on macOS) * Skip the tree tests. Something about the tree tests crashes the test runner.

…14834)

This is necessary to run `bazel` on Angular's CI

…r#14871)

)

…#15239)

This should fix the tests for AriaDescriber, AutofillMonitor, Portal, BottomSheet, Autocomplete, and Drawer.

…5255)

…15257)

…uery (angular#15267)

Reworks a test that depends on static queries and fails under Ivy.

* Fixes one unit test that was depending on static queries. * Fixes the remaining 16 failures that were due to some code that was commented out while waiting for a task which was resolved.

This makes the test pass in ivy (as well as ViewEngine) since attribute bindings are set during creating mode in ivy.

…r#15309) This makes a test pass both with ivy and ViewEngine

Fixes some tests that will fail under Ivy, because they depend on static queries.

…15330) Fixes some tests that fail under Ivy, because they depend on static queries.

…inserting (angular#15359) * fix(virtual-scroll): move views that are already attached instead of inserting * fix: add more static queries for cdk virtual scroll * refactor(button): use [attr.disabled] host binding in MatButton With ivy, MatAnchor will inherit the host bindings of MatButton. The `[disabled]` binding would then be an error since HTMLAnchorElement does not have a `disabled` property. To work around this, we can simply use the `disabled` attribute instead, which will always be reflected back into the property when it exists. Also add a missing `fixture.detectChanges()` to a test.

…#15414)

Fixes the chip list tests that are failing under Ivy due to a known breaking change.

7 tests are impacted

…lar#15440] (angular#15456)

)

Reworks the snack bar to account for a breaking change in Ivy.

ngbot · 2019-03-19T20:29:14Z

I see that you just added the pr: merge ready label, but the following checks are still failing:
     status "ci/circleci: api_golden_checks" is failing
     status "ci/circleci: bazel_build_test" is failing
     status "ci/circleci: build_release_packages" is failing
     status "ci/circleci: e2e_tests" is failing
     status "ci/circleci: lint" is failing
     status "ci/circleci: prerender_build" is failing
     status "ci/circleci: tests_browserstack" is failing
     status "ci/circleci: tests_local_browsers" is failing
     status "ci/circleci: tests_saucelabs" is failing
     missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

crisbeto · 2019-03-20T17:07:26Z

Closing in favor of #15551.

angular-automatic-lock-bot · 2019-09-10T16:01:18Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alxhub and others added 30 commits January 10, 2019 11:56

build: activate experimental Angular Ivy build of the demo app

9ff4d2d

See scripts/ivy/README.md for instructions.

fix: disable animation temporarily for ivy

3be11af

material demo app is running

678244b

chore(ivy): use yarn bazel consistently in install script (angular#…

fa7b7f3

…14834)

chore(ivy): add @bazel/bazel to devDependencies (angular#14835)

a3b27cc

This is necessary to run `bazel` on Angular's CI

chore(ivy): filter unit tests based on a blacklist (angular#14846)

e721385

test: report karma results as json (angular#14860)

e60bbd2

chore: skip CI for ivy-2019 branch (angular#14868)

5c86cc4

build: do run "build_release_packages" job in ivy-2019 branch (angula…

41f0185

…r#14871)

chore: update yarn lock

5be6a20

chore: add script to generate ivy test blacklist (angular#14877)

031b06f

chore(ivy): re-enable tree tests

614d827

chore: update zonejs to 0.8.29

ebff165

chore: add node shebang to ivy/fix-tsconfig.js script

f4219b5

chore: make scripts/ivy/fix-tsconfigs.js executable

e55e8e9

chore: simplify ivy/install-angular.sh

fa37a80

chore(ivy): rename "blacklist" to "blocklist"

348b3ef

chore(ivy): avoid global error issues with karma-jasmine

fca1c02

chore: disable tests that are failing *only* on angular CI

0cee02b

chore(ivy): add static flag to tab-related static queries (angular#15238

dc7467e

)

chore(ivy): add static flag to dialog-related static queries (angular…

c502f78

…#15239)

chore(ivy): add static flag to more queries (angular#15252)

7ee4193

This should fix the tests for AriaDescriber, AutofillMonitor, Portal, BottomSheet, Autocomplete, and Drawer.

chore(ivy): add static flag to tree-related static queries (angular#1…

f22561b

…5255)

chore(ivy): add static flag to table-related static queries (angular#…

576abc5

…15257)

chore(ivy): fix static query stragglers that were not marked static q…

ea7b7f2

…uery (angular#15267)

test(menu): refactor test that depends on static queries (angular#15289)

4d38453

Reworks a test that depends on static queries and fails under Ivy.

test(sidenav): fix sidenav failures under Ivy (angular#15300)

fcc0448

* Fixes one unit test that was depending on static queries. * Fixes the remaining 16 failures that were due to some code that was commented out while waiting for a task which was resolved.

test(grid-list): make error expectation less brittle (angular#15303)

f388871

This makes the test pass in ivy (as well as ViewEngine) since attribute bindings are set during creating mode in ivy.

test(slide-toggle): adding missing detectChanges() and tick() (angula…

669d586

…r#15309) This makes a test pass both with ivy and ViewEngine

jelbourn and others added 14 commits February 26, 2019 09:25

test(overlay): use static queries w/ overlay containers (angular#15301)

edf819e

test(select): update static query tests (angular#15320)

ba78acd

Fixes some tests that will fail under Ivy, because they depend on static queries.

test(expansion): rework tests that depend on static queries (angular#…

9473ce9

…15330) Fixes some tests that fail under Ivy, because they depend on static queries.

test(accordion): update static query test (angular#15357)

c068a53

fix: mark virtual scroll viewport queries as static (angular#15346)

fbbd5d0

fix: restore virtualForOf properties (angular#15358)

ddc81f1

test(table): remove unnecessary test (angular#15391)

ab8a338

fix: move detectChanges call in tree spec to include trackBy (angular…

171f128

…#15414)

test(chip-list): rework tests to work under Ivy (angular#15427)

e766a4f

Fixes the chip list tests that are failing under Ivy due to a known breaking change.

test(table): update static query test (angular#15450)

641e676

7 tests are impacted

fix(table): use default change detection strategy on table [from angu…

a3f4f43

…lar#15440] (angular#15456)

test(input): make the type validation test to pass in Ivy (angular#15461

04b029c

)

refactor(snack-bar): rework to account for ivy

29842aa

Reworks the snack bar to account for a breaking change in Ivy.

crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe labels Mar 19, 2019

crisbeto assigned josephperrott and mmalerba Mar 19, 2019

crisbeto requested review from jelbourn and josephperrott as code owners March 19, 2019 16:21

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 19, 2019

mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 19, 2019

kara force-pushed the ivy-2019 branch from 2e18640 to 44f185b Compare March 20, 2019 04:12

crisbeto mentioned this pull request Mar 20, 2019

refactor(snack-bar): rework to account for ivy (#15536) #15551

Merged

crisbeto closed this Mar 20, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(snack-bar): rework to account for ivy #15537

refactor(snack-bar): rework to account for ivy #15537

Uh oh!

crisbeto commented Mar 19, 2019

Uh oh!

ngbot bot commented Mar 19, 2019

Uh oh!

crisbeto commented Mar 20, 2019

Uh oh!

angular-automatic-lock-bot bot commented Sep 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

refactor(snack-bar): rework to account for ivy #15537

refactor(snack-bar): rework to account for ivy #15537

Uh oh!

Conversation

crisbeto commented Mar 19, 2019

Uh oh!

ngbot bot commented Mar 19, 2019

Uh oh!

crisbeto commented Mar 20, 2019

Uh oh!

angular-automatic-lock-bot bot commented Sep 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants