Skip to content

fix(table): use default change detection strategy on table [from #15440] #15456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2019
Merged

fix(table): use default change detection strategy on table [from #15440] #15456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions src/cdk/table/row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,9 @@
* found in the LICENSE file at https://angular.io/license
*/

import {
ChangeDetectionStrategy,
Component,
Directive,
IterableChanges,
IterableDiffer,
IterableDiffers,
OnChanges,
OnDestroy,
SimpleChanges,
TemplateRef,
ViewContainerRef,
ViewEncapsulation,
} from '@angular/core';
import {CanStick, CanStickCtor, mixinHasStickyInput} from './can-stick';
import {CdkCellDef, CdkColumnDef} from './cell';
import { Component, Directive, IterableChanges, IterableDiffer, IterableDiffers, OnChanges, OnDestroy, SimpleChanges, TemplateRef, ViewContainerRef, ViewEncapsulation } from '@angular/core';
import { CanStick, CanStickCtor, mixinHasStickyInput } from './can-stick';
import { CdkCellDef, CdkColumnDef } from './cell';

/**
* The row template that can be used by the mat-table. Should not be used outside of the
Expand Down Expand Up @@ -248,7 +235,6 @@ export class CdkCellOutlet implements OnDestroy {
'class': 'cdk-header-row',
'role': 'row',
},
changeDetection: ChangeDetectionStrategy.OnPush,
encapsulation: ViewEncapsulation.None,
})
export class CdkHeaderRow { }
Expand All @@ -263,7 +249,6 @@ export class CdkHeaderRow { }
'class': 'cdk-footer-row',
'role': 'row',
},
changeDetection: ChangeDetectionStrategy.OnPush,
encapsulation: ViewEncapsulation.None,
})
export class CdkFooterRow { }
Expand All @@ -277,7 +262,6 @@ export class CdkFooterRow { }
'class': 'cdk-row',
'role': 'row',
},
changeDetection: ChangeDetectionStrategy.OnPush,
encapsulation: ViewEncapsulation.None,
})
export class CdkRow { }
2 changes: 0 additions & 2 deletions src/cdk/table/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import {CollectionViewer, DataSource} from '@angular/cdk/collections';
import {
AfterContentChecked,
Attribute,
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
ContentChildren,
Expand Down Expand Up @@ -158,7 +157,6 @@ export interface RenderRow<T> {
'class': 'cdk-table',
},
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class CdkTable<T> implements AfterContentChecked, CollectionViewer, OnDestroy, OnInit {
private _document: Document;
Expand Down
4 changes: 0 additions & 4 deletions src/lib/table/row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/

import {
ChangeDetectionStrategy,
Component,
Directive,
ViewEncapsulation
Expand Down Expand Up @@ -63,7 +62,6 @@ export class MatRowDef<T> extends CdkRowDef<T> {}
'class': 'mat-header-row',
'role': 'row',
},
changeDetection: ChangeDetectionStrategy.OnPush,
encapsulation: ViewEncapsulation.None,
exportAs: 'matHeaderRow',
providers: [{provide: CdkHeaderRow, useExisting: MatHeaderRow}],
Expand All @@ -79,7 +77,6 @@ export class MatHeaderRow extends CdkHeaderRow { }
'class': 'mat-footer-row',
'role': 'row',
},
changeDetection: ChangeDetectionStrategy.OnPush,
encapsulation: ViewEncapsulation.None,
exportAs: 'matFooterRow',
providers: [{provide: CdkFooterRow, useExisting: MatFooterRow}],
Expand All @@ -95,7 +92,6 @@ export class MatFooterRow extends CdkFooterRow { }
'class': 'mat-row',
'role': 'row',
},
changeDetection: ChangeDetectionStrategy.OnPush,
encapsulation: ViewEncapsulation.None,
exportAs: 'matRow',
providers: [{provide: CdkRow, useExisting: MatRow}],
Expand Down
3 changes: 1 addition & 2 deletions src/lib/table/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import {CDK_TABLE_TEMPLATE, CdkTable} from '@angular/cdk/table';
import {ChangeDetectionStrategy, Component, ViewEncapsulation} from '@angular/core';
import {Component, ViewEncapsulation} from '@angular/core';

/**
* Wrapper for the CdkTable with Material design styles.
Expand All @@ -22,7 +22,6 @@ import {ChangeDetectionStrategy, Component, ViewEncapsulation} from '@angular/co
'class': 'mat-table',
},
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class MatTable<T> extends CdkTable<T> {
/** Overrides the sticky CSS class set by the `CdkTable`. */
Expand Down