Skip to content

Conversation

@crisbeto
Copy link
Member

Fixes some tests that fail under Ivy, because they depend on static queries.

Fixes some tests that fail under Ivy, because they depend on static queries.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 27, 2019
@jelbourn
Copy link
Member

Could you PR this into master as well? In general, I'd prefer any changes that are just detectChanges() to go into master and then cherry-pick them into ivy-2019

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 9473ce9 into angular:ivy-2019 Feb 27, 2019
crisbeto added a commit to crisbeto/angular that referenced this pull request Feb 27, 2019
Removes some tests, that were failing due to static queries, from the blocklist. Related Material PR angular/components#15330.
AndrewKushnir pushed a commit to angular/angular that referenced this pull request Feb 27, 2019
Removes some tests, that were failing due to static queries, from the blocklist. Related Material PR angular/components#15330.

PR Close #29011
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants