fix(moment-adapter): incorrectly deserializing moment dates and not setting locale on deserialized values #14685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting locale on deserialized values Fixes a couple of issues I noticed while doing the Luxon adapter: * If a `Moment` instance was passed in to `deserialize`, we were returning a new `Moment` instance set to the current date/time, rather than the ones from the passed-in object. * In some cases the object returned by `deserialize` didn't have its locale set to the one from the adapter.
googlebot
added
the
cla: yes
mmalerba
approved these changes
Jan 2, 2019
Contributor
|
merge safe since we don't sync moment adapter into google3 |
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…etting locale on deserialized values (angular#14685) Fixes a couple of issues I noticed while doing the Luxon adapter: * If a `Moment` instance was passed in to `deserialize`, we were returning a new `Moment` instance set to the current date/time, rather than the ones from the passed-in object. * In some cases the object returned by `deserialize` didn't have its locale set to the one from the adapter.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues I noticed while doing the Luxon adapter:
Momentinstance was passed in todeserialize, we were returning a newMomentinstance set to the current date/time, rather than the ones from the passed-in object.deserializedidn't have its locale set to the one from the adapter.