build: better sharing of material test utilities #13885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/material-shared-testing
branch
2 times, most recently
from
cbe3a5f to
e375f39
Compare
jelbourn
approved these changes
Oct 30, 2018
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Caretaker note: please update the copy config to omit the new testing directory for Google. Also, in the unlikely event that someone in Google depends on these month symbols, copy them into the offending application code.
jelbourn
added
pr: lgtm
action: merge
josephperrott
added
the
target: patch
devversion
force-pushed
the
build/material-shared-testing
branch
2 times, most recently
from
803a8b4 to
bb9ab21
Compare
Member
Author
|
@jelbourn Re-added the constants in favor of backwards compatibility. Please have another look. |
devversion
force-pushed
the
build/material-shared-testing
branch
from
bb9ab21 to
7485275
Compare
|
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
devversion
force-pushed
the
build/material-shared-testing
branch
from
7485275 to
ca1a099
Compare
devversion
force-pushed
the
build/material-shared-testing
branch
3 times, most recently
from
b497df3 to
a9aa104
Compare
Contributor
|
Sorry, can you rebase again? |
devversion
force-pushed
the
build/material-shared-testing
branch
from
a9aa104 to
21694ca
Compare
Member
Author
|
@andrewseguin This one is rebased now. It's just red because of the API guardian tests. Those should be fixed with #14144. |
* The slide toggle tests no longer import the test gesture config from `../slider/` * The datepicker month constants from `@angular/material/core` have been moved to `lib/testing`. The old export from `core` will be kept for backwards compatibility until V8
devversion
force-pushed
the
build/material-shared-testing
branch
from
21694ca to
45b3b13
Compare
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
* The slide toggle tests no longer import the test gesture config from `../slider/` * The datepicker month constants from `@angular/material/core` have been moved to `lib/testing`. The old export from `core` will be kept for backwards compatibility until V8
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
* The slide toggle tests no longer import the test gesture config from `../slider/` * The datepicker month constants from `@angular/material/core` have been moved to `lib/testing`. The old export from `core` will be kept for backwards compatibility until V8
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
../slider/@angular/material/corehave been moved tolib/testing. The old export fromcorewill be kept for backwards compatibility until V8