Skip to content

refactor(drag-drop): expose method for resetting the drag position #13673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2018
Merged

refactor(drag-drop): expose method for resetting the drag position #13673

merged 1 commit into from
Nov 8, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 18, 2018

Exposes an API that allows people to reset the position of a cdkDrag.

Fixes #13661.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 18, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 18, 2018
jelbourn
jelbourn approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018
@jelbourn
Copy link
Member

jelbourn commented Nov 3, 2018

@crisbeto passes presubmit, just needs rebase

@ngbot
Copy link

ngbot bot commented Nov 3, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@jelbourn
Copy link
Member

jelbourn commented Nov 5, 2018

...and this conflicted with the other drag-drop PR that needed rebase

@crisbeto
Copy link
Member Author

crisbeto commented Nov 5, 2018

Rebased again. I should stop putting all the new tests in the same place.

@vivian-hu-zz
Copy link
Contributor

vivian-hu-zz commented Nov 7, 2018

@crisbeto need rebase again.

@crisbeto
refactor(drag-drop): expose method for resetting the drag position
334d9e2 
Exposes an API that allows people to reset the position of a `cdkDrag`.

Fixes angular#13661.
@crisbeto
Copy link
Member Author

crisbeto commented Nov 8, 2018

Rebased.

@vivian-hu-zz vivian-hu-zz merged commit ba31c72 into angular:master Nov 8, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@crisbeto
refactor(drag-drop): expose method for resetting the drag position (#…
b802e39 
…13673)

Exposes an API that allows people to reset the position of a `cdkDrag`.

Fixes #13661.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

drag-drop: allow cancelation of dragged element

4 participants

@crisbeto @jelbourn @vivian-hu-zz @googlebot