build: fix schematics TS errors #13310
Conversation
crisbeto
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
src/lib/schematics/tsconfig.json
Outdated
| "paths": { | ||
| "@angular/cdk/schematics": ["../../../dist/packages/cdk/schematics/"] | ||
| "@angular/cdk/schematics": [ | ||
| "../../../dist/packages/cdk/schematics/", |
There was a problem hiding this comment.
@devversion I don't know whether this should still be here. I've left it in for now just in case. Also we have to look into why the CI doesn't fail for these. I took a quick look and it seemed like the TS compilation promise was rejecting as expected.
There was a problem hiding this comment.
Yeah this is odd. I assumed there are no "non-breaking" failures because the CI passed and gulp material:build-release:clean as well. I probably just didn't scroll up the whole log because it exited without errors.
Also, yeah, let's remove ../../../dist/packages/cdk/schematics here and just refer to the source. I do not recall why we always refer to dist/packages (in other entry-points of Material)
* Currently if the TS compilation (either through `ngc` or `tsc`) fails, the gulp tasks won't report the error properly because the `reject()` call of the Promise does not have any error message. This causes compilation failures to be ignored. See: angular#13310
Fixes some TS errors being logged out when building the schematics due to an outdated path in the `exclude` and an incorrect mapping in the `paths`.
crisbeto
force-pushed
the
schematics-ts-errors
branch
from
ec1ad83 to
68ed5f8
Compare
Currently if the TS compilation (either through `ngc` or `tsc`) fails, the gulp tasks won't report the error properly because the `reject()` call of the Promise does not have any error message. This causes compilation failures to be ignored. See: #13310
Fixes some TS errors being logged out when building the schematics due to an outdated path in the `exclude` and an incorrect mapping in the `paths`.
Currently if the TS compilation (either through `ngc` or `tsc`) fails, the gulp tasks won't report the error properly because the `reject()` call of the Promise does not have any error message. This causes compilation failures to be ignored. See: angular#13310
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Fixes some TS errors being logged out when building the schematics due to an outdated path in the
excludeand an incorrect mapping in thepaths.