Skip to content

fix(chips): invalid ripple color for selected chips #13271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2018
Merged

fix(chips): invalid ripple color for selected chips #13271

merged 1 commit into from
Nov 10, 2018

Conversation

@devversion
Copy link
Member

@devversion devversion commented Sep 23, 2018

  • In case a chip is selected and is solid colored, we need to make sure that the ripples have the proper color (similar to raised, flat and fab buttons)

@devversion devversion added the target: major This PR is targeted for the next major release label Sep 23, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 23, 2018
@devversion devversion mentioned this pull request Sep 24, 2018
Merged
@jelbourn jelbourn added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Oct 2, 2018
jelbourn
jelbourn approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Oct 19, 2018
@jelbourn jelbourn removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Nov 2, 2018
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Nov 3, 2018
@devversion
fix(chips): invalid ripple color for selected chips
afd9d29 
* In case a chip is selected and is solid colored, we need to make sure that the ripples have the proper color (similar to raised, flat and fab buttons)
@devversion devversion force-pushed the fix/chips-ripple-color-selected branch from c05d6fe to afd9d29 Compare November 8, 2018 20:04
@vivian-hu-zz vivian-hu-zz merged commit df5d18f into angular:master Nov 10, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@devversion
fix(chips): invalid ripple color for selected chips (#13271)
057eee1 
* In case a chip is selected and is solid colored, we need to make sure that the ripples have the proper color (similar to raised, flat and fab buttons)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @googlebot @vivian-hu-zz