Skip to content

fix(tooltip): text fields not editable if tooltip is applied in safari #12959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2018
Merged

fix(tooltip): text fields not editable if tooltip is applied in safari #12959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/lib/tooltip/tooltip.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,19 +790,20 @@ describe('MatTooltip', () => {
});

describe('special cases', () => {
it('should clear the `user-select` when a tooltip is set on a text field in iOS', () => {
platform.IOS = true;

it('should clear the `user-select` when a tooltip is set on a text field', () => {
const fixture = TestBed.createComponent(TooltipOnTextFields);
const instance = fixture.componentInstance;

fixture.detectChanges();

expect(instance.input.nativeElement.style.userSelect).toBeFalsy();
expect(instance.input.nativeElement.style.webkitUserSelect).toBeFalsy();
expect(instance.input.nativeElement.style.msUserSelect).toBeFalsy();

expect(instance.textarea.nativeElement.style.userSelect).toBeFalsy();
expect(instance.textarea.nativeElement.style.webkitUserSelect).toBeFalsy();
expect(instance.textarea.nativeElement.style.msUserSelect).toBeFalsy();
});

it('should clear the `-webkit-user-drag` on draggable elements', () => {
Expand Down
12 changes: 7 additions & 5 deletions src/lib/tooltip/tooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,13 +217,15 @@ export class MatTooltip implements OnDestroy {
.set('mouseenter', () => this.show())
.set('mouseleave', () => this.hide())
.forEach((listener, event) => element.addEventListener(event, listener));
} else if (_platform.IOS && (element.nodeName === 'INPUT' || element.nodeName === 'TEXTAREA')) {
}

if (element.nodeName === 'INPUT' || element.nodeName === 'TEXTAREA') {
// When we bind a gesture event on an element (in this case `longpress`), HammerJS
// will add some inline styles by default, including `user-select: none`. This is
// problematic on iOS, because it will prevent users from typing in inputs. If
// we're on iOS and the tooltip is attached on an input or textarea, we clear
// the `user-select` to avoid these issues.
element.style.webkitUserSelect = element.style.userSelect = '';
// problematic on iOS and in Safari, because it will prevent users from typing in inputs.
// Since `user-select: none` is not needed for the `longpress` event and can cause unexpected
// behavior for text fields, we always clear the `user-select` to avoid such issues.
element.style.webkitUserSelect = element.style.userSelect = element.style.msUserSelect = '';
}

// Hammer applies `-webkit-user-drag: none` on all elements by default,
Expand Down