Skip to content

Conversation

@crisbeto
Copy link
Member

Removes a workaround that was initially introduced to get #12182 through. The root issue has been resolved in #12876.

Removes a workaround that was initially introduced to get angular#12182 through. The root issue has been resolved in angular#12876.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 30, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 30, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 30, 2018
@jelbourn
Copy link
Member

Ugh, I had no idea that the issue might have been fixed by 3.0. I probably would have just gone straight to that (waiting for the Angular beta from last night)

@jelbourn jelbourn merged commit b2ae3f4 into angular:master Aug 30, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants