Skip to content

feat(chips): align with 2018 material design spec #12838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2018
Merged

feat(chips): align with 2018 material design spec #12838

merged 1 commit into from
Sep 19, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 26, 2018

Aligns the chips with the latest Material Design spec. Includes adding a new hover state.

angular_material_-_google_chrome_2018-08-26_14-04-55
angular_material_-_google_chrome_2018-08-26_14-04-36

@crisbeto
feat(chips): align with 2018 material design spec
7a027a3 
Aligns the chips with the latest Material Design spec. Includes adding a new hover state.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Aug 26, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner August 26, 2018 12:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 26, 2018
jelbourn
jelbourn approved these changes Aug 26, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 26, 2018
@mmalerba mmalerba merged commit 3cc9c67 into angular:master Sep 19, 2018
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @mmalerba