fix(badge): hide badges with no content #12239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
Similarly to `matTooltip`, these changes hide the badge if it doesn't have any content. Keeping an empty badge in the view doesn't make sense since it'll just be an empty circle.
crisbeto
force-pushed
the
hide-empty-badge
branch
from
124369a to
b607db7
Compare
josephperrott
pushed a commit
that referenced
this pull request
Jul 18, 2018
josephperrott
pushed a commit
that referenced
this pull request
Jul 18, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to
matTooltip, these changes hide the badge if it doesn't have any content. Keeping an empty badge in the view doesn't make sense since it'll just be an empty circle.