Skip to content

test(drag-drop): add missing unit tests #12219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2018
Merged

test(drag-drop): add missing unit tests #12219

merged 1 commit into from
Jul 17, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 15, 2018

  • Adds the missing unit tests for dragging items between containers and the drag utilities.
  • Handles some more edge cases in the drag utilities.

@crisbeto
test(drag-drop): add missing unit tests
d4c7efc 
* Adds the missing unit tests for dragging items between containers and the drag utilities.
* Handles some more edge cases in the drag utilities.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 15, 2018
josephperrott
josephperrott approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: master only labels Jul 16, 2018
jelbourn
jelbourn approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit 19326f7 into angular:master Jul 17, 2018
josephperrott pushed a commit that referenced this pull request Jul 17, 2018
@crisbeto @josephperrott
test(drag-drop): add missing unit tests (#12219)
531af85
josephperrott pushed a commit that referenced this pull request Jul 17, 2018
@crisbeto @josephperrott
test(drag-drop): add missing unit tests (#12219)
ac9d344
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @josephperrott @googlebot