From cd30c6b513b7a202d1d9ab23ca03362d37c893f5 Mon Sep 17 00:00:00 2001 From: crisbeto Date: Wed, 30 May 2018 20:04:22 +0300 Subject: [PATCH] chore: remove internal usages of deprecated APIs Removes some internal usages of APIs that we've marked as deprecated, but which have stable equivalents. Doesn't include logic that's in place for backward compatibility. --- src/cdk/a11y/key-manager/list-key-manager.spec.ts | 2 +- src/cdk/table/table.spec.ts | 2 +- src/lib/menu/menu-directive.ts | 2 +- src/lib/menu/menu-trigger.ts | 2 +- src/lib/menu/menu.spec.ts | 6 +++--- src/lib/snack-bar/snack-bar.spec.ts | 8 ++++---- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/cdk/a11y/key-manager/list-key-manager.spec.ts b/src/cdk/a11y/key-manager/list-key-manager.spec.ts index 297f4e85cceb..48db1161f948 100644 --- a/src/cdk/a11y/key-manager/list-key-manager.spec.ts +++ b/src/cdk/a11y/key-manager/list-key-manager.spec.ts @@ -759,7 +759,7 @@ describe('Key managers', () => { expect(keyManager.activeItemIndex) .toBe(0, `Expected first item of the list to be active.`); - keyManager.updateActiveItemIndex(1); + keyManager.updateActiveItem(1); expect(keyManager.activeItemIndex) .toBe(1, `Expected activeItemIndex to update after calling updateActiveItemIndex().`); expect(itemList.items[1].focus).not.toHaveBeenCalledTimes(1); diff --git a/src/cdk/table/table.spec.ts b/src/cdk/table/table.spec.ts index cdb21d42683f..83bd23ac6372 100644 --- a/src/cdk/table/table.spec.ts +++ b/src/cdk/table/table.spec.ts @@ -1612,7 +1612,7 @@ class WrapperCdkTableApp implements AfterContentInit { // Register the content's column, row, and header row definitions. this.columnDefs.forEach(columnDef => this.table.addColumnDef(columnDef)); this.rowDefs.forEach(rowDef => this.table.addRowDef(rowDef)); - this.table.setHeaderRowDef(this.headerRowDef); + this.table.addHeaderRowDef(this.headerRowDef); } } diff --git a/src/lib/menu/menu-directive.ts b/src/lib/menu/menu-directive.ts index b70d203a8d9c..0bc083347a4b 100644 --- a/src/lib/menu/menu-directive.ts +++ b/src/lib/menu/menu-directive.ts @@ -232,7 +232,7 @@ export class MatMenu implements AfterContentInit, MatMenuPanel, OnD ngAfterContentInit() { this._keyManager = new FocusKeyManager(this._items).withWrap().withTypeAhead(); - this._tabSubscription = this._keyManager.tabOut.subscribe(() => this.close.emit('tab')); + this._tabSubscription = this._keyManager.tabOut.subscribe(() => this.closed.emit('tab')); } ngOnDestroy() { diff --git a/src/lib/menu/menu-trigger.ts b/src/lib/menu/menu-trigger.ts index bb1b238734f5..fd8e906a8651 100644 --- a/src/lib/menu/menu-trigger.ts +++ b/src/lib/menu/menu-trigger.ts @@ -433,7 +433,7 @@ export class MatMenuTrigger implements AfterContentInit, OnDestroy { private _menuClosingActions() { const backdrop = this._overlayRef!.backdropClick(); const detachments = this._overlayRef!.detachments(); - const parentClose = this._parentMenu ? this._parentMenu.close : observableOf(); + const parentClose = this._parentMenu ? this._parentMenu.closed : observableOf(); const hover = this._parentMenu ? this._parentMenu._hovered().pipe( filter(active => active !== this._menuItemInstance), filter(() => this._menuOpen) diff --git a/src/lib/menu/menu.spec.ts b/src/lib/menu/menu.spec.ts index 74a80ccaaf46..470b1be3737f 100644 --- a/src/lib/menu/menu.spec.ts +++ b/src/lib/menu/menu.spec.ts @@ -1643,7 +1643,7 @@ class CustomMenu { [matMenuTriggerFor]="levelTwo" #alternateTrigger="matMenuTrigger">Toggle alternate menu - + - + - + diff --git a/src/lib/snack-bar/snack-bar.spec.ts b/src/lib/snack-bar/snack-bar.spec.ts index a39ade9aa8b7..25e6f9b51d68 100644 --- a/src/lib/snack-bar/snack-bar.spec.ts +++ b/src/lib/snack-bar/snack-bar.spec.ts @@ -317,17 +317,17 @@ describe('MatSnackBar', () => { })); it('should indicate in `afterClosed` whether it was dismissed by an action', fakeAsync(() => { - const closeSpy = jasmine.createSpy('dismiss spy'); + const dismissSpy = jasmine.createSpy('dismiss spy'); const snackBarRef = snackBar.open('Some content'); viewContainerFixture.detectChanges(); - snackBarRef.afterDismissed().subscribe(closeSpy); + snackBarRef.afterDismissed().subscribe(dismissSpy); - snackBarRef.closeWithAction(); + snackBarRef.dismissWithAction(); viewContainerFixture.detectChanges(); tick(); - expect(closeSpy).toHaveBeenCalledWith(jasmine.objectContaining({dismissedByAction: true})); + expect(dismissSpy).toHaveBeenCalledWith(jasmine.objectContaining({dismissedByAction: true})); tick(500); }));