refactor: address feedback

Author: crisbeto

src/lib/autocomplete/autocomplete.spec.ts

@@ -21,7 +21,7 @@ import {
   MdAutocomplete,
   MdAutocompleteModule,
   MdAutocompleteTrigger,
-  MdAutocompleteSelect,
+  MdAutocompleteSelectedEvent,
 } from './index';
 import {MdInputModule} from '../input/index';
 import {Subscription} from 'rxjs/Subscription';
@@ -1551,7 +1551,7 @@ describe('MdAutocomplete', () => {
       });
     }));
 
-  it('should call emit an event when an option is selected', fakeAsync(() => {
+  it('should emit an event when an option is selected', fakeAsync(() => {
     let fixture = TestBed.createComponent(AutocompleteWithSelectEvent);
 
     fixture.detectChanges();
@@ -1560,19 +1560,45 @@ describe('MdAutocomplete', () => {
     fixture.detectChanges();
 
     let options = overlayContainerElement.querySelectorAll('md-option') as NodeListOf<HTMLElement>;
-    let spy = fixture.componentInstance.select;
+    let spy = fixture.componentInstance.optionSelected;
 
     options[1].click();
     tick();
     fixture.detectChanges();
 
     expect(spy).toHaveBeenCalledTimes(1);
 
-    let event = spy.calls.mostRecent().args[0] as MdAutocompleteSelect;
+    let event = spy.calls.mostRecent().args[0] as MdAutocompleteSelectedEvent;
 
     expect(event.source).toBe(fixture.componentInstance.autocomplete);
     expect(event.option.value).toBe('Washington');
   }));
+
+  it('should emit an event when a newly-added option is selected', fakeAsync(() => {
+    let fixture = TestBed.createComponent(AutocompleteWithSelectEvent);
+
+    fixture.detectChanges();
+    fixture.componentInstance.trigger.openPanel();
+    tick();
+    fixture.detectChanges();
+
+    fixture.componentInstance.states.push('Puerto Rico');
+    fixture.detectChanges();
+
+    let options = overlayContainerElement.querySelectorAll('md-option') as NodeListOf<HTMLElement>;
+    let spy = fixture.componentInstance.optionSelected;
+
+    options[3].click();
+    tick();
+    fixture.detectChanges();
+
+    expect(spy).toHaveBeenCalledTimes(1);
+
+    let event = spy.calls.mostRecent().args[0] as MdAutocompleteSelectedEvent;
+
+    expect(event.source).toBe(fixture.componentInstance.autocomplete);
+    expect(event.option.value).toBe('Puerto Rico');
+  }));
 });
 
 @Component({
@@ -1857,7 +1883,8 @@ class AutocompleteWithGroups {
     <md-input-container>
       <input mdInput placeholder="State" [mdAutocomplete]="auto" [(ngModel)]="selectedState">
     </md-input-container>
-    <md-autocomplete #auto="mdAutocomplete" (select)="select($event)">
+
+    <md-autocomplete #auto="mdAutocomplete" (optionSelected)="optionSelected($event)">
       <md-option *ngFor="let state of states" [value]="state">
         <span>{{ state }}</span>
       </md-option>
@@ -1867,7 +1894,7 @@ class AutocompleteWithGroups {
 class AutocompleteWithSelectEvent {
   selectedState: string;
   states = ['New York', 'Washington', 'Oregon'];
-  select = jasmine.createSpy('select callback');
+  optionSelected = jasmine.createSpy('optionSelected callback');
 
   @ViewChild(MdAutocompleteTrigger) trigger: MdAutocompleteTrigger;
   @ViewChild(MdAutocomplete) autocomplete: MdAutocomplete;

src/lib/autocomplete/autocomplete.ts

@@ -32,11 +32,10 @@ import {ActiveDescendantKeyManager} from '@angular/cdk/a11y';
 let _uniqueAutocompleteIdCounter = 0;
 
 /** Event object that is emitted when an autocomplete option is selected */
-export class MdAutocompleteSelect {
+export class MdAutocompleteSelectedEvent {
   constructor(public source: MdAutocomplete, public option: MdOption) { }
 }
 
-export type AutocompletePositionY = 'above' | 'below';
 
 @Component({
   moduleId: module.id,
@@ -74,7 +73,8 @@ export class MdAutocomplete implements AfterContentInit {
   @Input() displayWith: ((value: any) => string) | null = null;
 
   /** Event that is emitted whenever an option from the list is selected. */
-  @Output() select: EventEmitter<MdAutocompleteSelect> = new EventEmitter<MdAutocompleteSelect>();
+  @Output() optionSelected: EventEmitter<MdAutocompleteSelectedEvent> =
+      new EventEmitter<MdAutocompleteSelectedEvent>();
 
   /** Unique ID to be used by autocomplete trigger's "aria-owns" property. */
   id: string = `md-autocomplete-${_uniqueAutocompleteIdCounter++}`;
@@ -110,8 +110,8 @@ export class MdAutocomplete implements AfterContentInit {
 
   /** Emits the `select` event. */
   _emitSelectEvent(option: MdOption): void {
-    const selectEvent = new MdAutocompleteSelect(this, option);
-    this.select.emit(selectEvent);
+    const event = new MdAutocompleteSelectedEvent(this, option);
+    this.optionSelected.emit(event);
   }
 
   /** Sets a class on the panel based on whether it is visible. */