refactor (MatDatepicker): make select a public method

Author: Tobias Schweizer

src/lib/datepicker/calendar.spec.ts

@@ -1,5 +1,5 @@
 import {Direction, Directionality} from '@angular/cdk/bidi';
-import {ENTER, RIGHT_ARROW,} from '@angular/cdk/keycodes';
+import {ENTER, RIGHT_ARROW} from '@angular/cdk/keycodes';
 import {
   dispatchFakeEvent,
   dispatchKeyboardEvent,

src/lib/datepicker/calendar.ts

@@ -340,9 +340,6 @@ export class MatCalendar<D> implements AfterContentInit, AfterViewChecked, OnDes
             (this.currentView == 'year' ? this.yearView : this.multiYearView);
 
     view.ngAfterContentInit();
-
-    // to be removed once test works
-    console.log(view._dateAdapter.today());
   }
 
   /** Handles date selection in the month view. */

src/lib/datepicker/datepicker-content.html

@@ -9,7 +9,7 @@
     [headerComponent]="datepicker.calendarHeaderComponent"
     [selected]="datepicker._selected"
     [@fadeInCalendar]="'enter'"
-    (selectedChange)="datepicker._select($event)"
+    (selectedChange)="datepicker.select($event)"
     (yearSelected)="datepicker._selectYear($event)"
     (monthSelected)="datepicker._selectMonth($event)"
     (_userSelection)="datepicker.close()">

src/lib/datepicker/datepicker.spec.ts

@@ -622,20 +622,6 @@ describe('MatDatepicker', () => {
         expect(testComponent.selected).toBeNull();
         expect(testComponent.datepickerInput.value).toBeNull();
 
-        let selected = new Date(2017, JAN, 1);
-        testComponent.datepicker._select(selected);
-        fixture.detectChanges();
-        flush();
-        fixture.detectChanges();
-
-        expect(testComponent.selected).toEqual(selected);
-        expect(testComponent.datepickerInput.value).toEqual(selected);
-      }));
-
-      it('should update model when date is selected using the public method', fakeAsync(() => {
-        expect(testComponent.selected).toBeNull();
-        expect(testComponent.datepickerInput.value).toBeNull();
-
         let selected = new Date(2017, JAN, 1);
         testComponent.datepicker.select(selected);
         fixture.detectChanges();
@@ -663,7 +649,7 @@ describe('MatDatepicker', () => {
 
         expect(inputEl.classList).toContain('ng-pristine');
 
-        testComponent.datepicker._select(new Date(2017, JAN, 1));
+        testComponent.datepicker.select(new Date(2017, JAN, 1));
         fixture.detectChanges();
         flush();
         fixture.detectChanges();
@@ -737,7 +723,7 @@ describe('MatDatepicker', () => {
 
         expect(inputEl.classList).toContain('ng-untouched');
 
-        testComponent.datepicker._select(new Date(2017, JAN, 1));
+        testComponent.datepicker.select(new Date(2017, JAN, 1));
         fixture.detectChanges();
         flush();
         fixture.detectChanges();
@@ -779,7 +765,7 @@ describe('MatDatepicker', () => {
         expect(testComponent.datepickerInput.value).toBeNull();
 
         let selected = new Date(2017, JAN, 1);
-        testComponent.datepicker._select(selected);
+        testComponent.datepicker.select(selected);
         fixture.detectChanges();
 
         expect(testComponent.formControl.value).toEqual(selected);

src/lib/datepicker/datepicker.ts

@@ -289,13 +289,8 @@ export class MatDatepicker<D> implements OnDestroy, CanColor {
     }
   }
 
-  /** Public method to select a date in the Datepicker */
-  select(date: D): void {
-    this._select(date);
-  }
-
   /** Selects the given date */
-  _select(date: D): void {
+  select(date: D): void {
     let oldValue = this._selected;
     this._selected = date;
     if (!this._dateAdapter.sameDate(oldValue, this._selected)) {