chore(docs): add types to public and jsdoc cleanup (#7711)

Author: amcdnl

src/cdk/accordion/accordion-item.ts

@@ -32,13 +32,13 @@ let nextId = 0;
 })
 export class CdkAccordionItem implements OnDestroy {
   /** Event emitted every time the AccordionItem is closed. */
-  @Output() closed = new EventEmitter<void>();
+  @Output() closed: EventEmitter<void> = new EventEmitter<void>();
   /** Event emitted every time the AccordionItem is opened. */
-  @Output() opened = new EventEmitter<void>();
+  @Output() opened: EventEmitter<void> = new EventEmitter<void>();
   /** Event emitted when the AccordionItem is destroyed. */
-  @Output() destroyed = new EventEmitter<void>();
+  @Output() destroyed: EventEmitter<void> = new EventEmitter<void>();
   /** The unique AccordionItem id. */
-  readonly id = `cdk-accordion-child-${nextId++}`;
+  readonly id: string = `cdk-accordion-child-${nextId++}`;
 
   /** Whether the AccordionItem is expanded. */
   @Input()

src/cdk/stepper/stepper.ts

@@ -171,13 +171,14 @@ export class CdkStepper implements OnDestroy {
 
   /** The step that is selected. */
   @Input()
-  get selected() { return this._steps.toArray()[this.selectedIndex]; }
+  get selected(): CdkStep { return this._steps.toArray()[this.selectedIndex]; }
   set selected(step: CdkStep) {
     this.selectedIndex = this._steps.toArray().indexOf(step);
   }
 
   /** Event emitted when the selected step has changed. */
-  @Output() selectionChange = new EventEmitter<StepperSelectionEvent>();
+  @Output() selectionChange: EventEmitter<StepperSelectionEvent>
+      = new EventEmitter<StepperSelectionEvent>();
 
   /** The index of the step that the focus can be set. */
   _focusIndex: number = 0;

src/cdk/table/table.ts

@@ -171,7 +171,7 @@ export class CdkTable<T> implements CollectionViewer, OnInit, AfterContentChecke
    * Stream containing the latest information on what rows are being displayed on screen.
    * Can be used by the data source to as a heuristic of what data should be provided.
    */
-  viewChange =
+  viewChange: BehaviorSubject<{start: number, end: number}> =
       new BehaviorSubject<{start: number, end: number}>({start: 0, end: Number.MAX_VALUE});
 
   // Placeholders within the table's template where the header and data rows will be inserted.

src/lib/button-toggle/button-toggle.ts

@@ -115,7 +115,7 @@ export class MatButtonToggleGroup extends _MatButtonToggleGroupMixinBase
     return this._vertical;
   }
 
-  set vertical(value) {
+  set vertical(value: boolean) {
     this._vertical = coerceBooleanProperty(value);
   }
 
@@ -141,7 +141,7 @@ export class MatButtonToggleGroup extends _MatButtonToggleGroupMixinBase
 
   /** Whether the toggle group is selected. */
   @Input()
-  get selected() {
+  get selected(): MatButtonToggle | null {
     return this._selected;
   }
 

src/lib/chips/chip-input.ts

@@ -53,7 +53,7 @@ export class MatChipInput {
    * Whether or not the chipEnd event will be emitted when the input is blurred.
    */
   @Input('matChipInputAddOnBlur')
-  get addOnBlur() { return this._addOnBlur; }
+  get addOnBlur(): boolean { return this._addOnBlur; }
   set addOnBlur(value: boolean) { this._addOnBlur = coerceBooleanProperty(value); }
   _addOnBlur: boolean = false;
 
@@ -67,7 +67,7 @@ export class MatChipInput {
 
   /** Emitted when a chip is to be added. */
   @Output('matChipInputTokenEnd')
-  chipEnd = new EventEmitter<MatChipInputEvent>();
+  chipEnd: EventEmitter<MatChipInputEvent> = new EventEmitter<MatChipInputEvent>();
 
   /** The input's placeholder text. */
   @Input() placeholder: string = '';
@@ -127,5 +127,5 @@ export class MatChipInput {
     this._chipList.stateChanges.next();
   }
 
-  focus() { this._inputElement.focus(); }
+  focus(): void { this._inputElement.focus(); }
 }

src/lib/chips/chip-list.ts

@@ -227,15 +227,15 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo
     this._id = value;
     this.stateChanges.next();
   }
-  get id() { return this._id || this._uid; }
+  get id(): string { return this._id || this._uid; }
 
   /** Required for FormFieldControl. Whether the chip list is required. */
   @Input()
-  set required(value: any) {
+  set required(value: boolean) {
     this._required = coerceBooleanProperty(value);
     this.stateChanges.next();
   }
-  get required() {
+  get required(): boolean {
     return this._required;
   }
 
@@ -245,7 +245,7 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo
     this._placeholder = value;
     this.stateChanges.next();
   }
-  get placeholder() {
+  get placeholder(): string {
     return this._chipInput ? this._chipInput.placeholder : this._placeholder;
   }
 
@@ -260,6 +260,7 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo
     return (!this._chipInput || this._chipInput.empty) && this.chips.length === 0;
   }
 
+  /** @docs-private */
   get shouldLabelFloat(): boolean {
     return !this.empty || this.focused;
   }
@@ -315,7 +316,7 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo
    * to facilitate the two-way binding for the `value` input.
    * @docs-private
    */
-  @Output() valueChange = new EventEmitter<any>();
+  @Output() valueChange: EventEmitter<any> = new EventEmitter<any>();
 
   /** The chip components contained within this chip list. */
   @ContentChildren(MatChip) chips: QueryList<MatChip>;
@@ -389,7 +390,10 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo
     this._chipInput = inputElement;
   }
 
-  // Implemented as part of MatFormFieldControl.
+  /**
+   * Implemented as part of MatFormFieldControl.
+   * @docs-private
+   */
   setDescribedByIds(ids: string[]) { this._ariaDescribedby = ids.join(' '); }
 
   // Implemented as part of ControlValueAccessor
@@ -416,6 +420,7 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo
     this.stateChanges.next();
   }
 
+  /** @docs-private */
   onContainerClick() {
     this.focus();
   }
@@ -424,7 +429,7 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo
    * Focuses the the first non-disabled chip in this chip list, or the associated input when there
    * are no eligible chips.
    */
-  focus() {
+  focus(): void {
     // TODO: ARIA says this should focus the first `selected` chip if any are selected.
     // Focus on first element if there's no chipInput inside chip-list
     if (this._chipInput && this._chipInput.focused) {

src/lib/chips/chip.ts

@@ -151,7 +151,8 @@ export class MatChip extends _MatChipMixinBase implements FocusableOption, OnDes
   _onBlur = new Subject<MatChipEvent>();
 
   /** Emitted when the chip is selected or deselected. */
-  @Output() selectionChange = new EventEmitter<MatChipSelectionChange>();
+  @Output() selectionChange: EventEmitter<MatChipSelectionChange>
+      = new EventEmitter<MatChipSelectionChange>();
 
   /** Emitted when the chip is destroyed. */
   @Output() destroyed = new EventEmitter<MatChipEvent>();
@@ -160,16 +161,16 @@ export class MatChip extends _MatChipMixinBase implements FocusableOption, OnDes
    * Emitted when the chip is destroyed.
    * @deprecated Use 'destroyed' instead.
    */
-  @Output() destroy = this.destroyed;
+  @Output() destroy: EventEmitter<MatChipEvent> = this.destroyed;
 
   /** Emitted when a chip is to be removed. */
-  @Output() removed = new EventEmitter<MatChipEvent>();
+  @Output() removed: EventEmitter<MatChipEvent> = new EventEmitter<MatChipEvent>();
 
   /**
    * Emitted when a chip is to be removed.
    * @deprecated Use `removed` instead.
    */
-  @Output('remove') onRemove = this.removed;
+  @Output('remove') onRemove: EventEmitter<MatChipEvent> = this.removed;
 
   get ariaSelected(): string | null {
     return this.selectable ? this.selected.toString() : null;

src/lib/datepicker/datepicker-input.ts

@@ -155,8 +155,8 @@ export class MatDatepickerInput<D> implements AfterContentInit, ControlValueAcce
 
   /** Whether the datepicker-input is disabled. */
   @Input()
-  get disabled() { return !!this._disabled; }
-  set disabled(value: any) {
+  get disabled(): boolean { return !!this._disabled; }
+  set disabled(value: boolean) {
     const newValue = coerceBooleanProperty(value);
 
     if (this._disabled !== newValue) {
@@ -167,10 +167,12 @@ export class MatDatepickerInput<D> implements AfterContentInit, ControlValueAcce
   private _disabled: boolean;
 
   /** Emits when a `change` event is fired on this `<input>`. */
-  @Output() dateChange = new EventEmitter<MatDatepickerInputEvent<D>>();
+  @Output() dateChange: EventEmitter<MatDatepickerInputEvent<D>>
+      = new EventEmitter<MatDatepickerInputEvent<D>>();
 
   /** Emits when an `input` event is fired on this `<input>`. */
-  @Output() dateInput = new EventEmitter<MatDatepickerInputEvent<D>>();
+  @Output() dateInput: EventEmitter<MatDatepickerInputEvent<D>>
+      = new EventEmitter<MatDatepickerInputEvent<D>>();
 
   /** Emits when the value changes (either due to user input or programmatic change). */
   _valueChange = new EventEmitter<D|null>();
@@ -263,6 +265,7 @@ export class MatDatepickerInput<D> implements AfterContentInit, ControlValueAcce
     this._disabledChange.complete();
   }
 
+  /** @docs-private */
   registerOnValidatorChange(fn: () => void): void {
     this._validatorOnChange = fn;
   }

src/lib/datepicker/datepicker.ts

@@ -163,7 +163,7 @@ export class MatDatepicker<D> implements OnDestroy {
    * Emits new selected date when selected date changes.
    * @deprecated Switch to the `dateChange` and `dateInput` binding on the input element.
    */
-  @Output() selectedChanged = new EventEmitter<D>();
+  @Output() selectedChanged: EventEmitter<D> = new EventEmitter<D>();
 
   /** Classes to be passed to the date picker panel. Supports the same syntax as `ngClass`. */
   @Input() panelClass: string | string[];
@@ -181,7 +181,7 @@ export class MatDatepicker<D> implements OnDestroy {
   private _opened = false;
 
   /** The id for the datepicker calendar. */
-  id = `mat-datepicker-${datepickerUid++}`;
+  id: string = `mat-datepicker-${datepickerUid++}`;
 
   /** The currently selected date. */
   get _selected(): D | null { return this._validSelected; }

src/lib/dialog/dialog-ref.ts

@@ -31,7 +31,7 @@ export class MatDialogRef<T, R = any> {
   componentInstance: T;
 
   /** Whether the user is allowed to close the dialog. */
-  disableClose = this._containerInstance._config.disableClose;
+  disableClose: boolean | undefined = this._containerInstance._config.disableClose;
 
   /** Subject for notifying the user that the dialog has finished opening. */
   private _afterOpen = new Subject<void>();