Skip to content

Commit a18a195

Browse files
devversionjelbourn
authored andcommitted
build: serve ivy dev-app with lazy loading (#15557)
* Revert "Revert "chore(dev-app): add lazy loading (#15522)"" This reverts commit 44f185b. * build: serve ivy dev-app with lazy loading * Updates the Ivy script/build pipeline to support lazy-loading with the dev-app. * Removes duplicate lazy routes (otherwise causes error within rollup) * Ensures Ivy Angular install script ensures clean Ivy packages are installed * Ensures Ivy `build.sh` script works if Gulp is not installed globally.
1 parent 0489ec1 commit a18a195

File tree

70 files changed

+2104
-436
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+2104
-436
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
/src/dev-app/connected-overlay/** @jelbourn @crisbeto
112112
/src/dev-app/dataset/** @andrewseguin
113113
/src/dev-app/datepicker/** @mmalerba
114-
/src/dev-app/dev-app-layout/** @mmalerba
114+
/src/dev-app/dev-app/** @mmalerba
115115
/src/dev-app/dialog/** @jelbourn @crisbeto
116116
/src/dev-app/drag-drop/** @crisbeto
117117
/src/dev-app/drawer/** @mmalerba

package.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,12 @@
125125
"node-sass": "^4.11.0",
126126
"parse5": "^5.0.0",
127127
"protractor": "^5.4.1",
128+
"requirejs": "^2.3.6",
128129
"resolve-bin": "^0.4.0",
129-
"rollup": "^0.56.3",
130-
"rollup-plugin-alias": "^1.4.0",
131-
"rollup-plugin-node-resolve": "^3.0.3",
130+
"rollup": "^1.7.0",
131+
"rollup-plugin-alias": "^1.5.1",
132+
"rollup-plugin-commonjs": "^9.2.1",
133+
"rollup-plugin-node-resolve": "^4.0.1",
132134
"run-sequence": "^1.2.2",
133135
"scss-bundle": "^2.0.1-beta.7",
134136
"selenium-webdriver": "^3.6.0",

scripts/ivy/build.sh

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,22 @@ set -e
44

55
echo ">>> Build Material"
66
rm -rf dist
7-
gulp build:devapp
7+
yarn gulp build:devapp
88

99
echo ">>> Rebuild dev-app with ngtsc"
1010
node_modules/.bin/ngc -p src/dev-app/tsconfig-build.json
1111

12-
echo ">>> Bundle demo-app with SystemJS"
13-
node ./src/dev-app/systemjs-bundle.js
12+
echo ">>> Bundling dev-app with Rollup"
13+
node ./src/dev-app/rollup-bundles.js
1414

15-
echo ">>> Assembling app"
16-
mkdir dist/demo
17-
cp dist/packages/dev-app/bundle.js dist/demo
15+
echo ">>> Copying assets to output"
1816
cp src/dev-app/index.html dist/demo
1917
cp dist/packages/dev-app/theme.css dist/demo
2018
cp 'node_modules/@webcomponents/custom-elements/custom-elements.min.js' dist/demo
2119
cp node_modules/core-js/client/core.js dist/demo
22-
cp node_modules/systemjs/dist/system.src.js dist/demo
20+
cp node_modules/requirejs/require.js dist/demo
2321
cp node_modules/zone.js/dist/zone.js dist/demo
2422
cp node_modules/hammerjs/hammer.min.js dist/demo
2523

2624
echo ">>> Done."
27-
echo "Output: $(pwd)/dist/demo"
25+
echo "Output: $(pwd)/dist/demo"

scripts/ivy/install-angular.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ function build_angular_packages() {
2121
function install_angular_package() {
2222
name=$1
2323
echo " @angular/$name"
24+
rm -Rf "node_modules/@angular/${name}"
2425
cp -r "${output_path}/${name}/npm_package" "node_modules/@angular/${name}"
2526
}
2627

src/dev-app/autocomplete/autocomplete-demo-module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
MatFormFieldModule,
1717
MatInputModule
1818
} from '@angular/material';
19+
import {RouterModule} from '@angular/router';
1920
import {AutocompleteDemo} from './autocomplete-demo';
2021

2122
@NgModule({
@@ -28,6 +29,7 @@ import {AutocompleteDemo} from './autocomplete-demo';
2829
MatFormFieldModule,
2930
MatInputModule,
3031
ReactiveFormsModule,
32+
RouterModule.forChild([{path: '', component: AutocompleteDemo}]),
3133
],
3234
declarations: [AutocompleteDemo],
3335
})

src/dev-app/badge/badge-demo-module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {CommonModule} from '@angular/common';
1010
import {NgModule} from '@angular/core';
1111
import {FormsModule} from '@angular/forms';
1212
import {MatBadgeModule, MatButtonModule, MatIconModule} from '@angular/material';
13+
import {RouterModule} from '@angular/router';
1314
import {BadgeDemo} from './badge-demo';
1415

1516
@NgModule({
@@ -19,6 +20,7 @@ import {BadgeDemo} from './badge-demo';
1920
MatBadgeModule,
2021
MatButtonModule,
2122
MatIconModule,
23+
RouterModule.forChild([{path: '', component: BadgeDemo}]),
2224
],
2325
declarations: [BadgeDemo],
2426
})

src/dev-app/baseline/baseline-demo-module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import {
1717
MatSelectModule,
1818
MatToolbarModule
1919
} from '@angular/material';
20+
import {RouterModule} from '@angular/router';
2021
import {BaselineDemo} from './baseline-demo';
2122

2223
@NgModule({
@@ -29,6 +30,7 @@ import {BaselineDemo} from './baseline-demo';
2930
MatRadioModule,
3031
MatSelectModule,
3132
MatToolbarModule,
33+
RouterModule.forChild([{path: '', component: BaselineDemo}]),
3234
],
3335
declarations: [BaselineDemo],
3436
})

src/dev-app/bottom-sheet/bottom-sheet-demo-module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import {
2020
MatListModule,
2121
MatSelectModule
2222
} from '@angular/material';
23+
import {RouterModule} from '@angular/router';
2324
import {BottomSheetDemo, ExampleBottomSheet} from './bottom-sheet-demo';
2425

2526
@NgModule({
@@ -35,6 +36,7 @@ import {BottomSheetDemo, ExampleBottomSheet} from './bottom-sheet-demo';
3536
MatInputModule,
3637
MatListModule,
3738
MatSelectModule,
39+
RouterModule.forChild([{path: '', component: BottomSheetDemo}]),
3840
],
3941
declarations: [BottomSheetDemo, ExampleBottomSheet],
4042
entryComponents: [ExampleBottomSheet],

src/dev-app/button-toggle/button-toggle-demo-module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {CommonModule} from '@angular/common';
1010
import {NgModule} from '@angular/core';
1111
import {FormsModule} from '@angular/forms';
1212
import {MatButtonToggleModule, MatCheckboxModule, MatIconModule} from '@angular/material';
13+
import {RouterModule} from '@angular/router';
1314
import {ButtonToggleDemo} from './button-toggle-demo';
1415

1516
@NgModule({
@@ -19,6 +20,7 @@ import {ButtonToggleDemo} from './button-toggle-demo';
1920
MatButtonToggleModule,
2021
MatCheckboxModule,
2122
MatIconModule,
23+
RouterModule.forChild([{path: '', component: ButtonToggleDemo}]),
2224
],
2325
declarations: [ButtonToggleDemo],
2426
})

src/dev-app/button/button-demo-module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@
88

99
import {NgModule} from '@angular/core';
1010
import {MatButtonModule, MatIconModule} from '@angular/material';
11+
import {RouterModule} from '@angular/router';
1112
import {ButtonDemo} from './button-demo';
1213

1314
@NgModule({
1415
imports: [
1516
MatButtonModule,
1617
MatIconModule,
18+
RouterModule.forChild([{path: '', component: ButtonDemo}]),
1719
],
1820
declarations: [ButtonDemo],
1921
})

0 commit comments

Comments
 (0)