chore: update tslint to v5 and fix newly surfaced issues (#3958)

Author: jelbourn

package.json

@@ -109,7 +109,7 @@
     "stylelint": "^7.8.0",
     "travis-after-modes": "0.0.7",
     "ts-node": "^3.0.0",
-    "tslint": "^4.4.2",
+    "tslint": "^5.0.0",
     "tslint-no-unused-var": "0.0.6",
     "typescript": "~2.1.1",
     "uglify-js": "^2.8.14",

src/lib/core/a11y/live-announcer.spec.ts

@@ -109,7 +109,7 @@ function getLiveElement(): Element {
 
 @Component({template: `<button (click)="announceText('Test')">Announce</button>`})
 class TestApp {
-  constructor(public live: LiveAnnouncer) { };
+  constructor(public live: LiveAnnouncer) { }
 
   announceText(message: string) {
     this.live.announce(message);

src/lib/core/a11y/live-announcer.ts

@@ -66,7 +66,7 @@ export class LiveAnnouncer {
 
 export function LIVE_ANNOUNCER_PROVIDER_FACTORY(parentDispatcher: LiveAnnouncer, liveElement: any) {
   return parentDispatcher || new LiveAnnouncer(liveElement);
-};
+}
 
 export const LIVE_ANNOUNCER_PROVIDER = {
   // If there is already a LiveAnnouncer available, use that. Otherwise, provide a new one.

src/lib/core/option/option.ts

@@ -172,7 +172,7 @@ export class MdOption {
   /** Emits the selection change event. */
   private _emitSelectionChangeEvent(isUserInput = false): void {
     this.onSelectionChange.emit(new MdOptionSelectionChange(this, isUserInput));
-  };
+  }
 
 }
 

src/lib/core/overlay/overlay-container.ts

@@ -57,7 +57,7 @@ export class OverlayContainer {
 
 export function OVERLAY_CONTAINER_PROVIDER_FACTORY(parentContainer: OverlayContainer) {
   return parentContainer || new OverlayContainer();
-};
+}
 
 export const OVERLAY_CONTAINER_PROVIDER = {
   // If there is already an OverlayContainer available, use that. Otherwise, provide a new one.

src/lib/core/selection/pseudo-checkbox/pseudo-checkbox.ts

@@ -41,7 +41,7 @@ export class MdPseudoCheckbox {
 
   /** Color of the checkbox. */
   @Input()
-  get color(): string { return this._color; };
+  get color(): string { return this._color; }
   set color(value: string) {
     if (value) {
       let nativeElement = this._elementRef.nativeElement;

src/lib/core/style/focus-origin-monitor.spec.ts

@@ -464,7 +464,7 @@ class PlainButton {
   template: `<button cdkMonitorElementFocus (cdkFocusChange)="focusChanged($event)"></button>`
 })
 class ButtonWithFocusClasses {
-  focusChanged(origin: FocusOrigin) {};
+  focusChanged(origin: FocusOrigin) {}
 }
 
 

src/lib/core/testing/wrapped-error-message.ts

@@ -5,4 +5,4 @@
 export function wrappedErrorMessage(e: Error) {
   const escapedMessage = e.message.replace(/[|\\{}()[\]^$+*?.]/g, '\\$&');
   return new RegExp(escapedMessage);
-};
+}

src/lib/dialog/dialog-config.ts

@@ -9,7 +9,7 @@ export interface DialogPosition {
   bottom?: string;
   left?: string;
   right?: string;
-};
+}
 
 /**
  * Configuration for opening a modal dialog with the MdDialog service.

src/lib/icon/icon.ts

@@ -250,7 +250,7 @@ export class MdIcon implements OnChanges, OnInit, AfterViewChecked {
 export function ICON_REGISTRY_PROVIDER_FACTORY(
     parentRegistry: MdIconRegistry, http: Http, sanitizer: DomSanitizer) {
   return parentRegistry || new MdIconRegistry(http, sanitizer);
-};
+}
 
 export const ICON_REGISTRY_PROVIDER = {
   // If there is already an MdIconRegistry available, use that. Otherwise, provide a new one.