build: ensure postinstall patches are applied properly

Ensures the postinstall fails if some replacements could not
be made. This ensures that we don't update Angular and invalidate
some of the workarounds. This would result in broken release output then.

Author: devversion

tools/bazel/postinstall-patches.js

@@ -6,9 +6,13 @@
 
 const shelljs = require('shelljs');
 const path = require('path');
+const fs = require('fs');
+
+/** Path to the project directory. */
+const projectDir = path.join(__dirname, '../..');
 
 shelljs.set('-e');
-shelljs.cd(path.join(__dirname, '../..'));
+shelljs.cd(projectDir);
 
 // Do not apply postinstall patches when running "postinstall" outside. The
 // "generate_build_file.js" file indicates that we run in Bazel managed node modules.
@@ -22,68 +26,91 @@ shelljs.exec('ngc -p angular-tsconfig.json');
 // Workaround for https://github.com/angular/angular/issues/30586. It's not possible to
 // enable tsickle decorator processing without enabling import rewriting to closure.
 // This replacement allows us to enable decorator processing without rewriting imports.
-shelljs.sed(
-    '-i', /(this\.transformTypesToClosure) = bazelOpts\.tsickle;/, '$1 = false;',
+searchAndReplace(
+    /(this\.transformTypesToClosure) = bazelOpts\.tsickle;/, '$1 = false;',
     'node_modules/@bazel/typescript/internal/tsc_wrapped/compiler_host.js');
-shelljs.sed(
-    '-i', 'bazelOpts\.tsickleExternsPath', 'null',
+searchAndReplace(
+    'bazelOpts\.tsickleExternsPath', 'null',
     'node_modules/@bazel/typescript/internal/tsc_wrapped/tsc_wrapped.js');
 
 // Workaround for https://github.com/angular/angular/issues/32389. We need to ensure
 // that tsickle is available for esm5 output re-compilations.
-shelljs.sed(
-    '-i', '@npm//@bazel/typescript/bin:tsc_wrapped',
+searchAndReplace(
+    '@npm//@bazel/typescript/bin:tsc_wrapped',
     '@angular_material//tools/bazel:tsc_wrapped_with_tsickle',
     'node_modules/@angular/bazel/src/esm5.bzl');
 
 // Workaround for: https://github.com/angular/angular/issues/32651. We just do not
 // generate re-exports for secondary entry-points. Similar to what "ng-packagr" does.
-shelljs.sed('-i', /(?!function\s+)createMetadataReexportFile\([^)]+\);/,
-    '', 'node_modules/@angular/bazel/src/ng_package/packager.js');
-shelljs.sed('-i', /(?!function\s+)createTypingsReexportFile\([^)]+\);/,
-    '', 'node_modules/@angular/bazel/src/ng_package/packager.js');
+searchAndReplace(
+    /(?!function\s+)createMetadataReexportFile\([^)]+\);/, '',
+    'node_modules/@angular/bazel/src/ng_package/packager.js');
+searchAndReplace(
+    /(?!function\s+)createTypingsReexportFile\([^)]+\);/, '',
+    'node_modules/@angular/bazel/src/ng_package/packager.js');
 
 // Workaround for: https://github.com/angular/angular/pull/32650
-shelljs.sed('-i', 'var indexFile;', `
+searchAndReplace(
+    'var indexFile;', `
   var publicApiFile = files.find(f => f.endsWith('/public-api.ts'));
   var moduleFile = files.find(f => f.endsWith('/module.ts'));
   var indexFile = publicApiFile || moduleFile;
-`, 'node_modules/@angular/compiler-cli/src/metadata/bundle_index_host.js');
-shelljs.sed('-i', 'var resolvedEntryPoint = null;', `
+`,
+    'node_modules/@angular/compiler-cli/src/metadata/bundle_index_host.js');
+searchAndReplace(
+    'var resolvedEntryPoint = null;', `
   var publicApiFile = tsFiles.find(f => f.endsWith('/public-api.ts'));
   var moduleFile = tsFiles.find(f => f.endsWith('/module.ts'));
   var resolvedEntryPoint = publicApiFile || moduleFile || null;
-`, 'node_modules/@angular/compiler-cli/src/ngtsc/entry_point/src/logic.js');
+`,
+    'node_modules/@angular/compiler-cli/src/ngtsc/entry_point/src/logic.js');
 
-// Workaround for https://github.com/angular/angular/issues/32603. Note that we don't
-// want to apply the patch if it has been applied already.
-if (!shelljs.test('-f', 'node_modules/@angular/bazel/src/ng_package/rollup_bin.js')) {
-  shelljs.cat(path.join(__dirname, './rollup_windows_arguments.patch')).exec('patch -p0');
-}
+// Workaround for https://github.com/angular/angular/issues/32603.
+shelljs.cat(path.join(__dirname, './rollup_windows_arguments.patch')).exec('patch -p0');
 
 // Workaround for: https://hackmd.io/MlqFp-yrSx-0mw4rD7dnQQ?both. We only want to discard
 // the metadata of files in the bazel managed node modules. That way we keep the default
 // behavior of ngc-wrapped except for dependencies between sources of the library. This makes
 // the "generateCodeForLibraries" flag more accurate in the Bazel environment where previous
 // compilations should not be treated as external libraries. Read more about this in the document.
-shelljs.sed('-i', /if \((this\.options\.generateCodeForLibraries === false)/, `
+searchAndReplace(
+    /if \((this\.options\.generateCodeForLibraries === false)/, `
   const fs = require('fs');
   const hasFlatModuleBundle = fs.existsSync(filePath.replace('.d.ts', '.metadata.json'));
   if ((filePath.includes('node_modules/') || !hasFlatModuleBundle) && $1`,
-  'node_modules/@angular/compiler-cli/src/transformers/compiler_host.js');
+    'node_modules/@angular/compiler-cli/src/transformers/compiler_host.js');
 shelljs.cat(path.join(__dirname, './flat_module_factory_resolution.patch')).exec('patch -p0');
 // The three replacements below ensure that metadata files can be read by NGC and
 // that metadata files are collected as Bazel action inputs.
-shelljs.sed('-i', /(const NGC_ASSETS = \/[^(]+\()([^)]*)(\).*\/;)/, '$1$2|metadata.json$3',
-  'node_modules/@angular/bazel/src/ngc-wrapped/index.js');
-shelljs.sed('-i', /^((\s*)results = depset\(dep.angular.summaries, transitive = \[results]\))$/,
-  `$1#\n$2results = depset(dep.angular.metadata, transitive = [results])`,
-  'node_modules/@angular/bazel/src/ng_module.bzl');
-shelljs.sed('-i',
-  /^((\s*)results = depset\(target.angular.summaries if hasattr\(target, "angular"\) else \[]\))$/,
-  `$1#\n$2results = depset(target.angular.metadata if hasattr(target, "angular") else [], transitive = [results])`,
-  'node_modules/@angular/bazel/src/ng_module.bzl');
+searchAndReplace(
+    /(const NGC_ASSETS = \/[^(]+\()([^)]*)(\).*\/;)/, '$1$2|metadata.json$3',
+    'node_modules/@angular/bazel/src/ngc-wrapped/index.js');
+searchAndReplace(
+    /^((\s*)results = depset\(dep.angular.summaries, transitive = \[results]\))$/m,
+    `$1#\n$2results = depset(dep.angular.metadata, transitive = [results])`,
+    'node_modules/@angular/bazel/src/ng_module.bzl');
+searchAndReplace(
+    /^((\s*)results = depset\(target.angular.summaries if hasattr\(target, "angular"\) else \[]\))$/m,
+    `$1#\n$2results = depset(target.angular.metadata if hasattr(target, "angular") else [], transitive = [results])`,
+    'node_modules/@angular/bazel/src/ng_module.bzl');
 // Ensure that "metadata" of transitive dependencies can be collected.
-shelljs.sed('-i', /("metadata": outs.metadata),/,
-  `$1 + [m for dep in ctx.attr.deps if hasattr(dep, "angular") for m in dep.angular.metadata],`,
-  'node_modules/@angular/bazel/src/ng_module.bzl');
+searchAndReplace(
+    /("metadata": outs.metadata),/,
+    `$1 + [m for dep in ctx.attr.deps if hasattr(dep, "angular") for m in dep.angular.metadata],`,
+    'node_modules/@angular/bazel/src/ng_module.bzl');
+
+/**
+ * Reads the specified file and replaces matches of the search expression
+ * with the given replacement. Throws if no changes were made.
+ */
+function searchAndReplace(search, replacement, relativeFilePath) {
+  const filePath = path.join(projectDir, relativeFilePath);
+  const originalContent = fs.readFileSync(filePath, 'utf8');
+  const newFileContent = originalContent.replace(search, replacement);
+
+  if (originalContent === newFileContent) {
+    throw Error(`Could not perform replacement in: ${filePath}.`);
+  }
+
+  fs.writeFileSync(filePath, newFileContent, 'utf8');
+}