feat: add support for noImplicitAny

Enables the `noImplicitAny` compiler option and fixes all of the resulting compiler errors.

Fixes #13330.

Author: crisbeto

src/cdk-experimental/dialog/dialog-injectors.ts

@@ -7,7 +7,11 @@
  */
 
 import {InjectionToken} from '@angular/core';
-import {ComponentType, Overlay, ScrollStrategy, BlockScrollStrategy} from '@angular/cdk/overlay';
+import {
+  ComponentType,
+  Overlay,
+  ScrollStrategy,
+} from '@angular/cdk/overlay';
 import {DialogRef} from './dialog-ref';
 import {CdkDialogContainer} from './dialog-container';
 import {DialogConfig} from './dialog-config';
@@ -31,7 +35,7 @@ export const DIALOG_CONTAINER =
 
 /** @docs-private */
 export function MAT_DIALOG_SCROLL_STRATEGY_PROVIDER_FACTORY(overlay: Overlay):
-    () => BlockScrollStrategy {
+    () => ScrollStrategy {
   return () => overlay.scrollStrategies.block();
 }
 

src/cdk-experimental/dialog/dialog.ts

@@ -13,7 +13,8 @@ import {
   Injectable,
   Injector,
   Inject,
-  ComponentRef
+  ComponentRef,
+  Type
 } from '@angular/core';
 import {ComponentPortal, PortalInjector, TemplatePortal} from '@angular/cdk/portal';
 import {of as observableOf, Observable, Subject, defer} from 'rxjs';
@@ -27,6 +28,7 @@ import {
   Overlay,
   OverlayRef,
   OverlayConfig,
+  ScrollStrategy,
 } from '@angular/cdk/overlay';
 import {startWith} from 'rxjs/operators';
 
@@ -44,6 +46,8 @@ import {
  */
 @Injectable()
 export class Dialog {
+  private _scrollStrategy: () => ScrollStrategy;
+
   /** Stream that emits when all dialogs are closed. */
   get _afterAllClosed(): Observable<void> {
     return this._parentDialog ? this._parentDialog.afterAllClosed : this._afterAllClosedBase;
@@ -67,8 +71,8 @@ export class Dialog {
   constructor(
       private overlay: Overlay,
       private injector: Injector,
-      @Inject(DIALOG_REF) private dialogRefConstructor,
-      @Inject(DIALOG_SCROLL_STRATEGY) private _scrollStrategy,
+      @Inject(DIALOG_REF) private dialogRefConstructor: Type<DialogRef<any>>,
+      @Inject(DIALOG_SCROLL_STRATEGY) scrollStrategy: any,
       @Optional() @SkipSelf() private _parentDialog: Dialog,
       @Optional() location: Location) {
 
@@ -78,6 +82,8 @@ export class Dialog {
     if (!_parentDialog && location) {
       location.subscribe(() => this.closeAll());
     }
+
+    this._scrollStrategy = scrollStrategy;
   }
 
   /** Gets an open dialog by id. */

src/cdk-experimental/tsconfig-build.json

@@ -8,6 +8,7 @@
     "noUnusedParameters": true,
     "strictNullChecks": true,
     "strictFunctionTypes": true,
+    "noImplicitAny": true,
     "importHelpers": true,
     "newLine": "lf",
     "module": "es2015",

src/cdk/accordion/accordion.spec.ts

@@ -66,12 +66,10 @@ describe('CdkAccordion', () => {
 
 @Component({template: `
   <cdk-accordion [multi]="multi">
-    <cdk-accordion-item #item1></cdk-accordion-item>
-    <cdk-accordion-item #item2></cdk-accordion-item>
+    <cdk-accordion-item></cdk-accordion-item>
+    <cdk-accordion-item></cdk-accordion-item>
   </cdk-accordion>`})
 class SetOfItems {
-  @ViewChild('item1') item1;
-  @ViewChild('item2') item2;
   multi: boolean = false;
 }
 

src/cdk/collections/tree-adapter.ts

@@ -27,5 +27,5 @@ export interface TreeDataNodeFlattener<T> {
    * Put node descendants of node in array.
    * If `onlyExpandable` is true, then only process expandable descendants.
    */
-  nodeDescendents(node: T, nodes: T[], onlyExpandable: boolean);
+  nodeDescendents(node: T, nodes: T[], onlyExpandable: boolean): void;
 }

src/cdk/drag-drop/drag-utils.spec.ts

@@ -57,7 +57,7 @@ describe('dragging utilities', () => {
     });
 
     it('should not do anything if the source array is empty', () => {
-      const a = [];
+      const a: number[] = [];
       const b = [3, 4, 5];
 
       transferArrayItem(a, b, 0, 0);

src/cdk/drag-drop/drag.ts

@@ -27,7 +27,7 @@ import {
   SkipSelf,
   ViewContainerRef,
 } from '@angular/core';
-import {merge, Observable, Subject} from 'rxjs';
+import {merge, Observable, Subject, Observer} from 'rxjs';
 import {takeUntil, take} from 'rxjs/operators';
 import {DragDropRegistry} from './drag-drop-registry';
 import {
@@ -173,15 +173,16 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
    * Emits as the user is dragging the item. Use with caution,
    * because this event will fire for every pixel that the user has dragged.
    */
-  @Output('cdkDragMoved') moved: Observable<CdkDragMove<T>> = Observable.create(observer => {
-    const subscription = this._moveEvents.subscribe(observer);
-    this._moveEventSubscriptions++;
-
-    return () => {
-      subscription.unsubscribe();
-      this._moveEventSubscriptions--;
-    };
-  });
+  @Output('cdkDragMoved') moved: Observable<CdkDragMove<T>> =
+      Observable.create((observer: Observer<CdkDragMove<T>>) => {
+        const subscription = this._moveEvents.subscribe(observer);
+        this._moveEventSubscriptions++;
+
+        return () => {
+          subscription.unsubscribe();
+          this._moveEventSubscriptions--;
+        };
+      });
 
   constructor(
     /** Element that the draggable is attached to. */
@@ -428,7 +429,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnDestroy {
    * Updates the item's position in its drop container, or moves it
    * into a new one, depending on its current drag position.
    */
-  private _updateActiveDropContainer({x, y}) {
+  private _updateActiveDropContainer({x, y}: Point) {
     // Drop container that draggable has been moved into.
     let newContainer = this.dropContainer._getSiblingContainerFromPosition(this, x, y);
 

src/cdk/layout/breakpoints-observer.spec.ts

@@ -137,7 +137,7 @@ export class FakeMediaQueryList implements MediaQueryList {
   /** The callback for change events. */
   addListenerCallback?: (mql: MediaQueryList) => void;
 
-  constructor(public matches, public media) {}
+  constructor(public matches: boolean, public media: string) {}
 
   /** Toggles the matches state and "emits" a change event. */
   setMatches(matches: boolean) {

src/cdk/observers/observe-content.ts

@@ -19,7 +19,7 @@ import {
   OnDestroy,
   Output,
 } from '@angular/core';
-import {Observable, Subject, Subscription} from 'rxjs';
+import {Observable, Subject, Subscription, Observer} from 'rxjs';
 import {debounceTime} from 'rxjs/operators';
 
 /**
@@ -65,7 +65,7 @@ export class ContentObserver implements OnDestroy {
   observe(elementOrRef: Element | ElementRef<Element>): Observable<MutationRecord[]> {
     const element = elementOrRef instanceof ElementRef ? elementOrRef.nativeElement : elementOrRef;
 
-    return Observable.create(observer => {
+    return Observable.create((observer: Observer<MutationRecord[]>) => {
       const stream = this._observeElement(element);
       const subscription = stream.subscribe(observer);
 

src/cdk/overlay/overlay-config.ts

@@ -8,8 +8,7 @@
 
 import {PositionStrategy} from './position/position-strategy';
 import {Direction, Directionality} from '@angular/cdk/bidi';
-import {ScrollStrategy} from './scroll/scroll-strategy';
-import {NoopScrollStrategy} from './scroll/noop-scroll-strategy';
+import {ScrollStrategy, NoopScrollStrategy} from './scroll/index';
 
 
 /** Initial configuration used when creating an overlay. */
@@ -62,9 +61,13 @@ export class OverlayConfig {
 
   constructor(config?: OverlayConfig) {
     if (config) {
-      Object.keys(config)
-        .filter(key => typeof config[key] !== 'undefined')
-        .forEach(key => this[key] = config[key]);
+      Object.keys(config).forEach(k => {
+        const key = k as keyof OverlayConfig;
+
+        if (typeof config[key] !== 'undefined') {
+          this[key] = config[key];
+        }
+      });
     }
   }
 }