chore: update tslint to latest version (#2952)

* chore: update tslint

* Updates TSLint to the latest version.
* Due to some breaking changes we had to temporary disable the `no-inferrable-types` rule. Need to revisit once palantir/tslint#2158 is addressed.

References #2175

* Use custom tslint rule

Author: devversion

package.json

@@ -97,7 +97,8 @@
     "stylelint": "^7.8.0",
     "travis-after-modes": "0.0.7",
     "ts-node": "^2.0.0",
-    "tslint": "^3.13.0",
+    "tslint": "^4.4.2",
+    "tslint-no-unused-var": "0.0.6",
     "typescript": "~2.0.10",
     "uglify-js": "^2.7.5",
     "web-animations-js": "^2.2.2"

src/lib/core/overlay/position/connected-position-strategy.ts

@@ -21,7 +21,7 @@ export type ElementBoundingPositions = {
   right: number;
   bottom: number;
   left: number;
-}
+};
 
 /**
  * A strategy for positioning overlays. Using this strategy, an overlay is given an

src/lib/progress-spinner/progress-spinner.ts

@@ -31,7 +31,7 @@ const MAX_ANGLE = 359.99 / 100;
 export type ProgressSpinnerMode = 'determinate' | 'indeterminate';
 
 type EasingFn = (currentTime: number, startValue: number,
-                 changeInValue: number, duration: number) => number
+                 changeInValue: number, duration: number) => number;
 
 
 /**

src/lib/tooltip/tooltip.ts

@@ -331,7 +331,7 @@ export class TooltipComponent {
       // trigger interaction and close the tooltip right after it was displayed.
       this._closeOnInteraction = false;
 
-      // Mark for check so if any parent component has set the 
+      // Mark for check so if any parent component has set the
       // ChangeDetectionStrategy to OnPush it will be checked anyways
       this._changeDetectorRef.markForCheck();
       setTimeout(() => { this._closeOnInteraction = true; }, 0);
@@ -352,7 +352,7 @@ export class TooltipComponent {
       this._visibility = 'hidden';
       this._closeOnInteraction = false;
 
-      // Mark for check so if any parent component has set the 
+      // Mark for check so if any parent component has set the
       // ChangeDetectionStrategy to OnPush it will be checked anyways
       this._changeDetectorRef.markForCheck();
     }, delay);

tslint.json

@@ -1,7 +1,11 @@
 {
+  "rulesDirectory": ["node_modules/tslint-no-unused-var"],
   "rules": {
     "max-line-length": [true, 100],
-    "no-inferrable-types": true,
+    // Disable this flag because of SHA tslint#48b0c597f9257712c7d1f04b55ed0aa60e333f6a
+    // TSLint now shows warnings if types for properties are inferred. This rule needs to be
+    // disabled because all properties need to have explicit types set to work for Dgeni.
+    "no-inferrable-types": false,
     "class-name": true,
     "comment-format": [
       true,
@@ -20,7 +24,7 @@
     "no-bitwise": true,
     "no-shadowed-variable": true,
     "no-unused-expression": true,
-    "no-unused-variable": [true, {"ignore-pattern": "^(_.*)$"}],
+    "no-unused-var": [true, {"ignore-pattern": "^(_.*)$"}],
     "one-line": [
       true,
       "check-catch",