build: add job to run tests with ivy

Introduces two new CI jobs that run tests with Ivy.
Pull requests will now run tests against a pinned
Angular/Ivy version. Additionally there is a cronjob
that runs the component tests with Ivy every hour
against Ivy from `angular/angular#master`. This allows
us to detect regressions very quickly.

Author: devversion

.circleci/config.yml

@@ -346,6 +346,63 @@ jobs:
     - run: node ./scripts/circleci/setup-angular-snapshots.js
     - run: ./scripts/circleci/run-local-browser-tests.sh
 
+
+  # ----------------------------------------------------------------------------
+  # Job that runs all Bazel tests against Ivy with the current Angular version
+  # specified in the project dev dependencies.
+  # ----------------------------------------------------------------------------
+  ivy_test:
+    <<: *job_defaults
+    resource_class: xlarge
+    environment:
+      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
+    steps:
+      - *checkout_code
+      - *restore_cache
+      - *copy_bazel_config
+      - *setup_bazel_remote_execution
+      - *yarn_install
+
+      # Setup Angular ivy snapshots built with ngtsc but locked to a specific tag. We
+      # cannot determine the tag automatically based on the Angular version specified in
+      # the "package.json" because the SHA is not known for the given release. Nor can
+      # we use ngcc to apply the ivy switches because ngcc currently does not handle the
+      # UMD format which is used by Bazel when running tests. UMD processing is in
+      # progress and tracked with FW-85.
+      - run: node ./scripts/circleci/setup-angular-snapshots.js --tag 8.0.0-rc.0-ivy-aot+bd37622
+      # Disable type checking when building with Ivy. This is necessary because
+      # type checking is not complete yet and can incorrectly break compilation.
+      # Issue is tracked with FW-1004.
+      - run: sed -i "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" tools/defaults.bzl
+      # Run project tests with ngtsc and the Ivy Angular packages.
+      - run: bazel build src/... --build_tag_filters=-docs-package --define=compile=aot
+      - run: bazel test src/... --build_tag_filters=-docs-package --define=compile=aot
+
+  # ----------------------------------------------------------------------------
+  # Job that runs all Bazel tests against Ivy from angular/angular#master.
+  # ----------------------------------------------------------------------------
+  ivy_snapshot_test_cronjob:
+    <<: *job_defaults
+    resource_class: xlarge
+    environment:
+      GCP_DECRYPT_TOKEN: *gcp_decrypt_token
+    steps:
+      - *checkout_code
+      - *restore_cache
+      - *copy_bazel_config
+      - *setup_bazel_remote_execution
+      - *yarn_install
+
+      # Setup Angular ivy snapshots built with ngtsc.
+      - run: node ./scripts/circleci/setup-angular-snapshots.js --tag master-ivy-aot
+      # Disable type checking when building with Ivy. This is necessary because
+      # type checking is not complete yet and can incorrectly break compilation.
+      # Issue is tracked with FW-1004.
+      - run: sed -i "s/\(_ENABLE_NG_TYPE_CHECKING = \)True/\1False/g" tools/defaults.bzl
+      # Run project tests with ngtsc and the Ivy Angular packages.
+      - run: bazel build src/... --build_tag_filters=-docs-package --define=compile=aot
+      - run: bazel test src/... --build_tag_filters=-docs-package --define=compile=aot
+
 # ----------------------------------------------------------------------------------------
 # Workflow definitions. A workflow usually groups multiple jobs together. This is useful if
 # one job depends on another.
@@ -360,6 +417,8 @@ workflows:
     jobs:
       - bazel_build_test:
           filters: *ignore_presubmit_branch_filter
+      - ivy_test:
+          filters: *ignore_presubmit_branch_filter
       - api_golden_checks:
           filters: *ignore_presubmit_branch_filter
 
@@ -398,17 +457,18 @@ workflows:
       - lint:
           filters: *ignore_presubmit_branch_filter
 
-  # Snapshot tests workflow that is scheduled to run all specified jobs at midnight everyday.
+  # Snapshot tests workflow that is scheduled to run all specified jobs every hour.
   # This workflow runs various jobs against the Angular snapshot builds from Github.
   snapshot_tests:
     jobs:
-      # Note that we need additional jobs for the nightly snapshot tests because there is no
-      # easy way to detect whether a job runs inside of a cronjob or specific workflow.
-      # See: https://circleci.com/ideas/?idea=CCI-I-295
+      # Note that we need additional jobs for the cronjob snapshot tests because there
+      # is no easy way to detect whether a job runs inside of a cronjob or specific
+      # workflow. See: https://circleci.com/ideas/?idea=CCI-I-295
       - snapshot_tests_local_browsers
+      - ivy_snapshot_test_cronjob
     triggers:
       - schedule:
-          cron: "0 0 * * *"
+          cron: "0 * * * *"
           filters:
             branches:
               only:

package.json

@@ -32,31 +32,31 @@
   "requiredAngularVersion": ">=8.0.0-rc.1",
   "requiredMDCVersion": "^1.1.0",
   "dependencies": {
-    "@angular/animations": "^8.0.0-rc.1",
-    "@angular/common": "^8.0.0-rc.1",
-    "@angular/compiler": "^8.0.0-rc.1",
-    "@angular/core": "^8.0.0-rc.1",
-    "@angular/elements": "^8.0.0-rc.1",
-    "@angular/forms": "^8.0.0-rc.1",
-    "@angular/platform-browser": "^8.0.0-rc.1",
+    "@angular/animations": "^8.0.0-rc.3",
+    "@angular/common": "^8.0.0-rc.3",
+    "@angular/compiler": "^8.0.0-rc.3",
+    "@angular/core": "^8.0.0-rc.3",
+    "@angular/elements": "^8.0.0-rc.3",
+    "@angular/forms": "^8.0.0-rc.3",
+    "@angular/platform-browser": "^8.0.0-rc.3",
     "@webcomponents/custom-elements": "^1.1.0",
     "core-js": "^2.6.1",
     "material-components-web": "^1.1.0",
     "rxjs": "^6.4.0",
     "systemjs": "0.19.43",
     "tsickle": "^0.35.0",
     "tslib": "^1.9.3",
-    "zone.js": "^0.9.0"
+    "zone.js": "~0.9.1"
   },
   "devDependencies": {
-    "@angular-devkit/core": "^8.0.0-rc.1",
-    "@angular-devkit/schematics": "^8.0.0-rc.1",
-    "@angular/bazel": "^8.0.0-rc.1",
-    "@angular/compiler-cli": "^8.0.0-rc.1",
-    "@angular/platform-browser-dynamic": "^8.0.0-rc.1",
-    "@angular/platform-server": "^8.0.0-rc.1",
-    "@angular/router": "^8.0.0-rc.1",
-    "@angular/upgrade": "^8.0.0-rc.1",
+    "@angular-devkit/core": "^8.0.0-rc.2",
+    "@angular-devkit/schematics": "^8.0.0-rc.2",
+    "@angular/bazel": "^8.0.0-rc.3",
+    "@angular/compiler-cli": "^8.0.0-rc.3",
+    "@angular/platform-browser-dynamic": "^8.0.0-rc.3",
+    "@angular/platform-server": "^8.0.0-rc.3",
+    "@angular/router": "^8.0.0-rc.3",
+    "@angular/upgrade": "^8.0.0-rc.3",
     "@bazel/bazel": "^0.24.1",
     "@bazel/ibazel": "^0.9.0",
     "@bazel/jasmine": "0.27.8",

scripts/circleci/setup-angular-snapshots.js

@@ -19,6 +19,7 @@ const {writeFileSync} = require('fs');
 const {join} = require('path');
 const {execSync} = require('child_process');
 
+const {tag} = require('minimist')(process.argv.slice(2), {string: ['tag']});
 const projectDir = join(__dirname, '../../');
 const packageJsonPath = join(projectDir, 'package.json');
 const packageJson = require(packageJsonPath);
@@ -30,13 +31,15 @@ packageJson['resolutions'] = packageJson['resolutions'] || {};
 // List that contains the names of all installed Angular packages (e.g. "@angular/core")
 const angularPackages = Object.keys({...packageJson.dependencies, ...packageJson.devDependencies})
   .filter(packageName => packageName.startsWith('@angular/'));
+const packageSuffix = tag ? ` (${tag})` : '';
 
 console.log(green('Setting up snapshot builds for:\n'));
-console.log(yellow(`  ${angularPackages.join('\n  ')}\n`));
+console.log(yellow(`  ${angularPackages.map(n => `${n}${packageSuffix}`).join('\n  ')}\n`));
 
 // Setup the snapshot version for each Angular package specified in the "package.json" file.
 angularPackages.forEach(packageName => {
-  const buildsUrl = `github:angular/${packageName.split('/')[1]}-builds`;
+  let buildsUrl = `github:angular/${packageName.split('/')[1]}-builds${tag ? `#${tag}` : ''}`;
+
   // Add resolutions for each package in the format "**/{PACKAGE}" so that all
   // nested versions of that specific Angular package will have the same version.
   packageJson.resolutions[`**/${packageName}`] = buildsUrl;

tools/defaults.bzl

@@ -11,6 +11,11 @@ _DEFAULT_TSCONFIG_BUILD = "//src:bazel-tsconfig-build.json"
 _DEFAULT_TSCONFIG_TEST = "//src:bazel-tsconfig-test.json"
 _DEFAULT_TS_TYPINGS = "@npm//typescript:typescript__typings"
 
+# Whether Angular type checking should be enabled or not. Enabled by
+# default but will be overwritten when running snapshots tests with Ivy
+# since type-checking is not complete yet. See FW-1004.
+_ENABLE_NG_TYPE_CHECKING = True
+
 # Re-exports to simplify build file load statements
 markdown_to_html = _markdown_to_html
 
@@ -55,6 +60,7 @@ def ng_module(deps = [], tsconfig = None, testonly = False, **kwargs):
       local_deps = local_deps + [d]
 
   _ng_module(
+    type_check = _ENABLE_NG_TYPE_CHECKING,
     deps = local_deps,
     tsconfig = tsconfig,
     testonly = testonly,