build: mark all e2e test suites as flaky within bazel (#16376)

devversion · andrewseguin · commit 535b9e9875ab · 2019-07-02T13:04:37.000-07:00
Marks all e2e test suites as flaky with Bazel's `flaky` rule
attribute. This should improve CI stability as e2e tests can
sometimes fail due to browser crashes, port collisions.
diff --git a/src/cdk-experimental/scrolling/BUILD.bazel b/src/cdk-experimental/scrolling/BUILD.bazel
@@ -1,7 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite")
+load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "protractor_web_test_suite")
 
 ng_module(
     name = "scrolling",
diff --git a/src/cdk-experimental/testing/BUILD.bazel b/src/cdk-experimental/testing/BUILD.bazel
@@ -1,7 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ng_module", "ng_web_test_suite")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
+load("//tools:defaults.bzl", "ng_module", "ng_web_test_suite", "protractor_web_test_suite")
 
 ng_module(
     name = "testing",
diff --git a/src/cdk/overlay/BUILD.bazel b/src/cdk/overlay/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material-experimental/mdc-button/BUILD.bazel b/src/material-experimental/mdc-button/BUILD.bazel
@@ -1,8 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module")
+load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite")
 
 ng_module(
     name = "mdc-button",
diff --git a/src/material-experimental/mdc-card/BUILD.bazel b/src/material-experimental/mdc-card/BUILD.bazel
@@ -1,8 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module")
+load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite")
 
 ng_module(
     name = "mdc-card",
diff --git a/src/material-experimental/mdc-checkbox/BUILD.bazel b/src/material-experimental/mdc-checkbox/BUILD.bazel
@@ -1,8 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "ts_library")
+load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "protractor_web_test_suite", "ts_library")
 
 ng_module(
     name = "mdc-checkbox",
diff --git a/src/material-experimental/mdc-chips/BUILD.bazel b/src/material-experimental/mdc-chips/BUILD.bazel
@@ -1,8 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module")
+load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite")
 
 ng_module(
     name = "mdc-chips",
diff --git a/src/material-experimental/mdc-menu/BUILD.bazel b/src/material-experimental/mdc-menu/BUILD.bazel
@@ -1,8 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite")
+load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "protractor_web_test_suite")
 
 ng_module(
     name = "mdc-menu",
diff --git a/src/material-experimental/mdc-radio/BUILD.bazel b/src/material-experimental/mdc-radio/BUILD.bazel
@@ -1,8 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module")
+load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite")
 
 ng_module(
     name = "mdc-radio",
diff --git a/src/material-experimental/mdc-slide-toggle/BUILD.bazel b/src/material-experimental/mdc-slide-toggle/BUILD.bazel
@@ -1,8 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite")
+load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite", "protractor_web_test_suite")
 
 ng_module(
     name = "mdc-slide-toggle",
diff --git a/src/material-experimental/mdc-tabs/BUILD.bazel b/src/material-experimental/mdc-tabs/BUILD.bazel
@@ -1,8 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module")
+load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite")
 
 ng_module(
     name = "mdc-tabs",
diff --git a/src/material/button-toggle/BUILD.bazel b/src/material/button-toggle/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/button/BUILD.bazel b/src/material/button/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/card/BUILD.bazel b/src/material/card/BUILD.bazel
@@ -1,8 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
-load("//tools:defaults.bzl", "markdown_to_html", "ng_e2e_test_library", "ng_module")
+load("//tools:defaults.bzl", "markdown_to_html", "ng_e2e_test_library", "ng_module", "protractor_web_test_suite")
 
 ng_module(
     name = "card",
diff --git a/src/material/checkbox/BUILD.bazel b/src/material/checkbox/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/dialog/BUILD.bazel b/src/material/dialog/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/expansion/BUILD.bazel b/src/material/expansion/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/grid-list/BUILD.bazel b/src/material/grid-list/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/icon/BUILD.bazel b/src/material/icon/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/input/BUILD.bazel b/src/material/input/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/list/BUILD.bazel b/src/material/list/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/menu/BUILD.bazel b/src/material/menu/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/progress-bar/BUILD.bazel b/src/material/progress-bar/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/progress-spinner/BUILD.bazel b/src/material/progress-spinner/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/radio/BUILD.bazel b/src/material/radio/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/sidenav/BUILD.bazel b/src/material/sidenav/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/slide-toggle/BUILD.bazel b/src/material/slide-toggle/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/stepper/BUILD.bazel b/src/material/stepper/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/tabs/BUILD.bazel b/src/material/tabs/BUILD.bazel
@@ -1,14 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
 load("@io_bazel_rules_sass//:defs.bzl", "sass_binary", "sass_library")
-load("@npm_angular_bazel//:index.bzl", "protractor_web_test_suite")
 load(
     "//tools:defaults.bzl",
     "markdown_to_html",
     "ng_e2e_test_library",
     "ng_module",
     "ng_test_library",
     "ng_web_test_suite",
+    "protractor_web_test_suite",
 )
 
 ng_module(
diff --git a/src/material/toolbar/BUILD.bazel b/src/material/toolbar/BUILD.bazel
diff --git a/tools/defaults.bzl b/tools/defaults.bzl
