Add sha to result

Author: tinayuangao

functions/github.ts

@@ -20,15 +20,13 @@ export function updateGithubStatus(event: firebaseFunctions.Event<any>) {
   }
   let result = event.data.val() == true;
   let prNumber = event.params.prNumber;
-  return event.data.ref.parent.child('sha').once('value').then((sha: firebaseAdmin.database.DataSnapshot) => {
-    return setGithubStatus(sha.val(),
-      {
-        result: result,
-        name: toolName,
-        description: `${toolName} ${result ? 'passed' : 'failed'}`,
-        url: `http://${authDomain}/${prNumber}`
-      },
-      repoSlug,
-      token);
-  });
+  return setGithubStatus(event.params.sha,
+    {
+      result: result,
+      name: toolName,
+      description: `${toolName} ${result ? 'passed' : 'failed'}`,
+      url: `http://${authDomain}/${prNumber}`
+    },
+    repoSlug,
+    token);
 }

functions/index.ts

@@ -116,5 +116,5 @@ exports.approveImages = firebaseFunctions.database.ref(approveImagesPath).onWrit
  * otherwise update github status to `failure`.
  * The Github Status Token is set in config.secret.github
  */
-const githubStatusPath = `${trustedReportPath}/result`;
+const githubStatusPath = `${trustedReportPath}/result/{sha}`;
 exports.githubStatus = firebaseFunctions.database.ref(githubStatusPath).onWrite(updateGithubStatus);

tools/gulp/tasks/screenshots.ts

@@ -50,7 +50,8 @@ function updateFileResult(database: firebase.database.Database, prNumber: string
 }
 
 function updateResult(database: firebase.database.Database, prNumber: string, result: boolean) {
-  return getPullRequestRef(database, prNumber).child('result').set(result).then(() => result);
+  return getPullRequestRef(database, prNumber).child('result')
+    .child(process.env['TRAVIS_PULL_REQUEST_SHA']).set(result).then(() => result);
 }
 
 function getPullRequestRef(database: firebase.database.Database | admin.database.Database,