refactor: switch acceptance members to type aliases (#17653)

* refactor: switch acceptance members to type aliases

Instead of manually typing the union types for boolean
and number inputs, we should use a type alias.

This allows us to make changes easier in the future, and
it avoids a lot of repetition.

* fixup! refactor: switch acceptance members to type aliases

Update goldens

* fix rebase issue

Author: devversion

src/cdk-experimental/scrolling/auto-size-virtual-scroll.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {coerceNumberProperty} from '@angular/cdk/coercion';
+import {coerceNumberProperty, NumberInput} from '@angular/cdk/coercion';
 import {ListRange} from '@angular/cdk/collections';
 import {
   CdkVirtualScrollViewport,
@@ -464,6 +464,6 @@ export class CdkAutoSizeVirtualScroll implements OnChanges {
     this._scrollStrategy.updateBufferSize(this.minBufferPx, this.maxBufferPx);
   }
 
-  static ngAcceptInputType_minBufferPx: number | string | null | undefined;
-  static ngAcceptInputType_maxBufferPx: number | string | null | undefined;
+  static ngAcceptInputType_minBufferPx: NumberInput;
+  static ngAcceptInputType_maxBufferPx: NumberInput;
 }

src/cdk/a11y/focus-trap/focus-trap.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {coerceBooleanProperty} from '@angular/cdk/coercion';
+import {BooleanInput, coerceBooleanProperty} from '@angular/cdk/coercion';
 import {DOCUMENT} from '@angular/common';
 import {
   AfterContentInit,
@@ -419,6 +419,6 @@ export class CdkTrapFocus implements OnDestroy, AfterContentInit, DoCheck {
     }
   }
 
-  static ngAcceptInputType_enabled: boolean | string | null | undefined;
-  static ngAcceptInputType_autoCapture: boolean | string | null | undefined;
+  static ngAcceptInputType_enabled: BooleanInput;
+  static ngAcceptInputType_autoCapture: BooleanInput;
 }

src/cdk/accordion/accordion-item.ts

@@ -18,7 +18,7 @@ import {
 } from '@angular/core';
 import {UniqueSelectionDispatcher} from '@angular/cdk/collections';
 import {CdkAccordion} from './accordion';
-import {coerceBooleanProperty} from '@angular/cdk/coercion';
+import {BooleanInput, coerceBooleanProperty} from '@angular/cdk/coercion';
 import {Subscription} from 'rxjs';
 
 /** Used to generate unique ID for each accordion item. */
@@ -153,6 +153,6 @@ export class CdkAccordionItem implements OnDestroy {
     });
   }
 
-  static ngAcceptInputType_expanded: boolean | string | null | undefined;
-  static ngAcceptInputType_disabled: boolean | string | null | undefined;
+  static ngAcceptInputType_expanded: BooleanInput;
+  static ngAcceptInputType_disabled: BooleanInput;
 }

src/cdk/accordion/accordion.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {coerceBooleanProperty} from '@angular/cdk/coercion';
+import {BooleanInput, coerceBooleanProperty} from '@angular/cdk/coercion';
 import {Directive, Input, OnChanges, OnDestroy, SimpleChanges} from '@angular/core';
 import {Subject} from 'rxjs';
 
@@ -60,5 +60,5 @@ export class CdkAccordion implements OnDestroy, OnChanges {
     }
   }
 
-  static ngAcceptInputType_multi: boolean | string | null | undefined;
+  static ngAcceptInputType_multi: BooleanInput;
 }

src/cdk/coercion/boolean-property.ts

@@ -6,6 +6,12 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+/**
+ * Type describing the allowed values for a boolean input.
+ * @docs-private
+ */
+export type BooleanInput = string | boolean | null | undefined;
+
 /** Coerces a data-bound value (typically a string) to a boolean. */
 export function coerceBooleanProperty(value: any): boolean {
   return value != null && `${value}` !== 'false';

src/cdk/coercion/number-property.ts

@@ -6,6 +6,12 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
+/**
+ * Type describing the allowed values for a number input
+ * @docs-private
+ */
+export type NumberInput = string | number | null | undefined;
+
 /** Coerces a data-bound value (typically a string) to a number. */
 export function coerceNumberProperty(value: any): number;
 export function coerceNumberProperty<D>(value: any, fallback: D): number | D;

src/cdk/drag-drop/directives/drag-handle.ts

@@ -7,7 +7,7 @@
  */
 
 import {Directive, ElementRef, Inject, Optional, Input, OnDestroy} from '@angular/core';
-import {coerceBooleanProperty} from '@angular/cdk/coercion';
+import {BooleanInput, coerceBooleanProperty} from '@angular/cdk/coercion';
 import {Subject} from 'rxjs';
 import {CDK_DRAG_PARENT} from '../drag-parent';
 import {toggleNativeDragInteractions} from '../drag-styling';
@@ -47,5 +47,5 @@ export class CdkDragHandle implements OnDestroy {
     this._stateChanges.complete();
   }
 
-  static ngAcceptInputType_disabled: boolean | string | null | undefined;
+  static ngAcceptInputType_disabled: BooleanInput;
 }

src/cdk/drag-drop/directives/drag.ts

@@ -30,7 +30,12 @@ import {
   ChangeDetectorRef,
   isDevMode,
 } from '@angular/core';
-import {coerceBooleanProperty, coerceNumberProperty, coerceElement} from '@angular/cdk/coercion';
+import {
+  coerceBooleanProperty,
+  coerceNumberProperty,
+  coerceElement,
+  BooleanInput
+} from '@angular/cdk/coercion';
 import {Observable, Observer, Subject, merge} from 'rxjs';
 import {startWith, take, map, takeUntil, switchMap, tap} from 'rxjs/operators';
 import {
@@ -409,7 +414,7 @@ export class CdkDrag<T = any> implements AfterViewInit, OnChanges, OnDestroy {
     });
   }
 
-  static ngAcceptInputType_disabled: boolean | string | null | undefined;
+  static ngAcceptInputType_disabled: BooleanInput;
 }
 
 /** Gets the closest ancestor of an element that matches a selector. */

src/cdk/drag-drop/directives/drop-list-group.ts

@@ -7,7 +7,7 @@
  */
 
 import {Directive, OnDestroy, Input} from '@angular/core';
-import {coerceBooleanProperty} from '@angular/cdk/coercion';
+import {BooleanInput, coerceBooleanProperty} from '@angular/cdk/coercion';
 
 /**
  * Declaratively connects sibling `cdkDropList` instances together. All of the `cdkDropList`
@@ -35,5 +35,5 @@ export class CdkDropListGroup<T> implements OnDestroy {
     this._items.clear();
   }
 
-  static ngAcceptInputType_disabled: boolean | string | null | undefined;
+  static ngAcceptInputType_disabled: BooleanInput;
 }

src/cdk/drag-drop/directives/drop-list.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {coerceArray, coerceBooleanProperty} from '@angular/cdk/coercion';
+import {BooleanInput, coerceArray, coerceBooleanProperty} from '@angular/cdk/coercion';
 import {
   ContentChildren,
   ElementRef,
@@ -332,7 +332,7 @@ export class CdkDropList<T = any> implements AfterContentInit, OnDestroy {
     });
   }
 
-  static ngAcceptInputType_disabled: boolean | string | null | undefined;
-  static ngAcceptInputType_sortingDisabled: boolean | string | null | undefined;
-  static ngAcceptInputType_autoScrollDisabled: boolean | string | null | undefined;
+  static ngAcceptInputType_disabled: BooleanInput;
+  static ngAcceptInputType_sortingDisabled: BooleanInput;
+  static ngAcceptInputType_autoScrollDisabled: BooleanInput;
 }