perf: allow assertions to be removed in production mode

Wraps all assertions in `ngDevMode` checks so that they can be stripped away in production mode. Furthermore, changes all the places where we were using the old `isDevMode` check.

Author: crisbeto

src/BUILD.bazel

@@ -2,6 +2,7 @@ load("@npm_bazel_typescript//:index.bzl", "ts_config")
 load("//src/cdk:config.bzl", "CDK_ENTRYPOINTS")
 load("//src/material:config.bzl", "MATERIAL_ENTRYPOINTS", "MATERIAL_TESTING_ENTRYPOINTS")
 load("//tools/dgeni:index.bzl", "dgeni_api_docs")
+load("//tools:defaults.bzl", "ts_library")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -43,3 +44,8 @@ dgeni_api_docs(
     },
     tags = ["docs-package"],
 )
+
+ts_library(
+    name = "dev_mode_types",
+    srcs = ["dev-mode-types.d.ts"],
+)

src/cdk-experimental/dialog/BUILD.bazel

@@ -11,6 +11,7 @@ ng_module(
     assets = [":dialog-container.css"] + glob(["**/*.html"]),
     module_name = "@angular/cdk-experimental/dialog",
     deps = [
+        "//src:dev_mode_types",
         "//src/cdk/a11y",
         "//src/cdk/bidi",
         "//src/cdk/keycodes",

src/cdk-experimental/dialog/dialog-container.ts

@@ -171,7 +171,7 @@ export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
    * @param portal Portal to be attached as the dialog content.
    */
   attachComponentPortal<T>(portal: ComponentPortal<T>): ComponentRef<T> {
-    if (this._portalHost.hasAttached()) {
+    if (this._portalHost.hasAttached() && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throwDialogContentAlreadyAttachedError();
     }
 
@@ -183,7 +183,7 @@ export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
    * @param portal Portal to be attached as the dialog content.
    */
   attachTemplatePortal<C>(portal: TemplatePortal<C>): EmbeddedViewRef<C> {
-    if (this._portalHost.hasAttached()) {
+    if (this._portalHost.hasAttached() && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throwDialogContentAlreadyAttachedError();
     }
 
@@ -197,7 +197,7 @@ export class CdkDialogContainer extends BasePortalOutlet implements OnDestroy {
    * @breaking-change 10.0.0
    */
   attachDomPortal = (portal: DomPortal) => {
-    if (this._portalHost.hasAttached()) {
+    if (this._portalHost.hasAttached() && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throwDialogContentAlreadyAttachedError();
     }
 

src/cdk-experimental/dialog/dialog.ts

@@ -106,7 +106,7 @@ export class Dialog implements OnDestroy {
   openFromComponent<T>(component: ComponentType<T>, config?: DialogConfig): DialogRef<any> {
     config = this._applyConfigDefaults(config);
 
-    if (config.id && this.getById(config.id)) {
+    if (config.id && this.getById(config.id) && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throw Error(`Dialog with id "${config.id}" exists already. The dialog id must be unique.`);
     }
 
@@ -125,7 +125,7 @@ export class Dialog implements OnDestroy {
   openFromTemplate<T>(template: TemplateRef<T>, config?: DialogConfig): DialogRef<any> {
     config = this._applyConfigDefaults(config);
 
-    if (config.id && this.getById(config.id)) {
+    if (config.id && this.getById(config.id) && (typeof ngDevMode === 'undefined' || ngDevMode)) {
       throw Error(`Dialog with id "${config.id}" exists already. The dialog id must be unique.`);
     }
 

src/cdk-experimental/menu/BUILD.bazel

@@ -10,6 +10,7 @@ ng_module(
     ),
     module_name = "@angular/cdk-experimental/menu",
     deps = [
+        "//src:dev_mode_types",
         "//src/cdk/a11y",
         "//src/cdk/bidi",
         "//src/cdk/coercion",

src/cdk-experimental/scrolling/BUILD.bazel

@@ -11,6 +11,7 @@ ng_module(
     ),
     module_name = "@angular/cdk-experimental/scrolling",
     deps = [
+        "//src:dev_mode_types",
         "//src/cdk/coercion",
         "//src/cdk/collections",
         "//src/cdk/scrolling",

src/cdk-experimental/scrolling/auto-size-virtual-scroll.ts

@@ -72,8 +72,10 @@ export class AutoSizeVirtualScrollStrategy implements VirtualScrollStrategy {
   /** @docs-private Implemented as part of VirtualScrollStrategy. */
   scrolledIndexChange = new Observable<number>(() => {
     // TODO(mmalerba): Implement.
-    throw Error('cdk-virtual-scroll: scrolledIndexChange is currently not supported for the' +
-        ' autosize scroll strategy');
+    if (typeof ngDevMode === 'undefined' || ngDevMode) {
+      throw Error('cdk-virtual-scroll: scrolledIndexChange is currently not supported for the' +
+          ' autosize scroll strategy');
+    }
   });
 
   /** The attached viewport. */
@@ -164,9 +166,11 @@ export class AutoSizeVirtualScrollStrategy implements VirtualScrollStrategy {
 
   /** Scroll to the offset for the given index. */
   scrollToIndex(): void {
-    // TODO(mmalerba): Implement.
-    throw Error('cdk-virtual-scroll: scrollToIndex is currently not supported for the autosize'
-        + ' scroll strategy');
+    if (typeof ngDevMode === 'undefined' || ngDevMode) {
+      // TODO(mmalerba): Implement.
+      throw Error('cdk-virtual-scroll: scrollToIndex is currently not supported for the autosize'
+          + ' scroll strategy');
+    }
   }
 
   /**

src/cdk-experimental/tsconfig-tests.json

@@ -21,7 +21,8 @@
   },
   "include": [
     "**/index.ts",
-    "**/*.spec.ts"
+    "**/*.spec.ts",
+    "../dev-mode-types.d.ts"
   ],
   "exclude": [
     "**/*.e2e.spec.ts"

src/cdk-experimental/tsconfig.json

@@ -9,5 +9,5 @@
       "@angular/cdk-experimental/*": ["../cdk-experimental/*"]
     }
   },
-  "include": ["./**/*.ts"]
+  "include": ["./**/*.ts", "../dev-mode-types.d.ts"]
 }

src/cdk/a11y/BUILD.bazel

@@ -18,6 +18,7 @@ ng_module(
     ),
     module_name = "@angular/cdk/a11y",
     deps = [
+        "//src:dev_mode_types",
         "//src/cdk/coercion",
         "//src/cdk/keycodes",
         "//src/cdk/observers",