Fixing some stuff since rc-1 (#2347)

* Adding a sample repo
* Drop updateMetatdata
* Fix the zone tests
* Drop the manual side-effect imports

Author: jamesdaniels

README.md

@@ -34,7 +34,6 @@ Get your first application up and running by following [our quickstart guide](do
 import { Component } from '@angular/core';
 import { AngularFirestore } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
-import 'firebase/firestore';
 
 @Component({
   selector: 'app-root',

docs/firestore/collections.md

@@ -11,7 +11,6 @@ The `AngularFirestoreCollection` service is a wrapper around the native Firestor
 import { Component } from '@angular/core';
 import { AngularFirestore, AngularFirestoreCollection } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
-import 'firebase/firestore';
 
 export interface Item { name: string; }
 
@@ -90,7 +89,6 @@ There are multiple ways of streaming collection data from Firestore.
 import { Component } from '@angular/core';
 import { AngularFirestore, AngularFirestoreCollection } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
-import 'firebase/firestore';
 
 export interface Item { id: string; name: string; }
 
@@ -143,7 +141,6 @@ import { Component } from '@angular/core';
 import { AngularFirestore, AngularFirestoreCollection } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
-import 'firebase/firestore';
 
 export interface Shirt { name: string; price: number; }
 export interface ShirtId extends Shirt { id: string; }
@@ -192,7 +189,6 @@ import { Component } from '@angular/core';
 import { AngularFirestore, AngularFirestoreCollection } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
-import 'firebase/firestore';
 
 export interface AccountDeposit { description: string; amount: number; }
 export interface AccountDepoistId extends AccountDeposit { id: string; }
@@ -238,7 +234,6 @@ import { Component } from '@angular/core';
 import { AngularFirestore, AngularFirestoreCollection } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
-import 'firebase/firestore';
 
 export interface AccountLogItem { description: string; amount: number; }
 export interface AccountLogItemId extends AccountLogItem { id: string; }
@@ -288,7 +283,6 @@ There are three `DocumentChangeType`s in Firestore: `added`, `removed`, and `mod
 import { Component } from '@angular/core';
 import { AngularFirestore, AngularFirestoreCollection } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
-import 'firebase/firestore';
 
 @Component({
   selector: 'app-root',

docs/firestore/documents.md

@@ -11,7 +11,6 @@ The `AngularFirestoreDocument` service is a wrapper around the native Firestore
 import { Component } from '@angular/core';
 import { AngularFirestore, AngularFirestoreDocument } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
-import 'firebase/firestore';
 
 export interface Item { name: string; }
 

docs/firestore/querying-collections.md

@@ -86,7 +86,6 @@ import { Component } from '@angular/core';
 import { AngularFirestore } from '@angular/fire/firestore';
 import { Observable, BehaviorSubject, combineLatest } from 'rxjs';
 import { switchMap } from 'rxjs/operators';
-import 'firebase/firestore';
 
 export interface Item {
   text: string;

docs/install-and-setup.md

@@ -93,7 +93,6 @@ Open `/src/app/app.component.ts`, and make sure to modify/delete any tests to ge
 ```ts
 import { Component } from '@angular/core';
 import { AngularFirestore } from '@angular/fire/firestore';
-import 'firebase/firestore';
 
 @Component({
   selector: 'app-root',
@@ -115,7 +114,6 @@ In `/src/app/app.component.ts`:
 import { Component } from '@angular/core';
 import { AngularFirestore } from '@angular/fire/firestore';
 import { Observable } from 'rxjs';
-import 'firebase/firestore';
 
 @Component({
   selector: 'app-root',

docs/rtdb/lists.md

@@ -18,7 +18,6 @@ Replace your  `/src/app/app.component.ts` from previous step to look like below.
 ```ts
 import { Component } from '@angular/core';
 import { AngularFireDatabase } from '@angular/fire/database';
-import 'firebase/database';
 
 @Component({
   selector: 'app-root',
@@ -53,7 +52,6 @@ Update `/src/app/app.component.ts` to import `AngularFireList` from `@angular/fi
 import { Component } from '@angular/core';
 import { AngularFireDatabase } from '@angular/fire/database';
 import { Observable } from 'rxjs';
-import 'firebase/database';
 
 @Component({
   selector: 'app-root',
@@ -211,7 +209,6 @@ import { Component } from '@angular/core';
 import { AngularFireDatabase, AngularFireList } from '@angular/fire/database';
 import { Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
-import 'firebase/database';
 
 @Component({
   selector: 'app-root',

docs/rtdb/objects.md

@@ -18,7 +18,6 @@ If you've followed the earlier step "Installation and Setup"  your `/src/app/app
 import { Component } from '@angular/core';
 import { AngularFireDatabase } from '@angular/fire/database';
 import { Observable } from 'rxjs';
-import 'firebase/database';
 
 @Component({
   selector: 'app-root',
@@ -51,7 +50,6 @@ Then in your template, you can use the `async` pipe to unwrap the binding.
 import { Component } from '@angular/core';
 import { AngularFireDatabase } from '@angular/fire/database';
 import { Observable } from 'rxjs';
-import 'firebase/database';
 
 @Component({
   selector: 'app-root',
@@ -130,7 +128,6 @@ itemRef.remove();
 import { Component } from '@angular/core';
 import { AngularFireDatabase, AngularFireObject } from '@angular/fire/database';
 import { Observable } from 'rxjs';
-import 'firebase/database';
 
 @Component({
   selector: 'app-root',

docs/rtdb/querying-lists.md

@@ -82,7 +82,6 @@ import { Component } from '@angular/core';
 import { AngularFireDatabase, AngularFireAction } from '@angular/fire/database';
 import { Observable, Subscription, BehaviorSubject } from 'rxjs';
 import { switchMap } from 'rxjs/operators';
-import 'firebase/database';
 
 @Component({
   selector: 'app-root',

docs/storage/storage.md

@@ -13,7 +13,6 @@ import { AppComponent } from './app.component';
 import { AngularFireModule } from '@angular/fire';
 import { AngularFireStorageModule } from '@angular/fire/storage';
 import { environment } from '../environments/environment';
-import 'firebase/storage';
 
 @NgModule({
   imports: [
@@ -48,7 +47,6 @@ Once the `AngularFireStorageModule` is registered you can inject the `AngularFir
 ```ts
 import { Component } from '@angular/core';
 import { AngularFireStorage } from '@angular/fire/storage';
-import 'firebase/storage';
 
 @Component({
   selector: 'app-component',
@@ -77,7 +75,6 @@ There are three options for uploading files.
 ```ts
 import { Component } from '@angular/core';
 import { AngularFireStorage } from '@angular/fire/storage';
-import 'firebase/storage';
 
 @Component({
   selector: 'app-root',
@@ -101,7 +98,6 @@ export class AppComponent {
 ```ts
 import { Component } from '@angular/core';
 import { AngularFireStorage } from '@angular/fire/storage';
-import 'firebase/storage';
 
 @Component({
   selector: 'app-root',
@@ -125,7 +121,6 @@ export class AppComponent {
 ```ts
 import { Component } from '@angular/core';
 import { AngularFireStorage } from '@angular/fire/storage';
-import 'firebase/storage';
 
 @Component({
   selector: 'app-root',

docs/version-6-upgrade.md

@@ -15,6 +15,5 @@ We're aiming to release 6.0 with an upgrade schematic to automate most of the re
 * Dropped `@angular/fire/firebase-node` and `@angular/fire/database-depreciated`
 * We make use of Proxy in more modules, you'll need to polyfill if you want to support IE 11
 * We've standardized our DI Token naming conventions across all modules
-* `AngularFirestoreModule` no longer imports `firebase/firestore` on it's own to remain side-effect free, you'll need to `import 'firebase/firestore'` before you inject it. A similar changes has been made to `AngularFireStorage` and `AngularFireDatabase`
 * `AngularFireAuth` has dropped the `auth` property and instead Promise Proxies the underlying Firebase `auth.Auth` instance; allowing your development experience to more closely mirror the JS SDK. Similar changes have been made to `AngularFireFunctions`, `AngularFireMessaging`, and `AngularFirePerformance`.
 * `AngularFireAuthGuard` and `canActivate` have dropped support for raw pipes, this was never working correctly in AOT