Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Conversation

@chalin
Copy link
Contributor

@chalin chalin commented Oct 3, 2016

  • Fix Dart API page style (style files placed under /resources/css/vendor/dartdoc) issues including breadcrumbs, class summary column placement and floating/fixed footer:
    • Use custom bootstrap grid system styles
    • Cache a copy of the dartdoc static-assets styles.css w/ footer styles disabled.
  • Alternate page layout controlled by jade2ng harp global

Fixes #2510

- Use custom bootstrap grid system styles
- Cache a copy of the dartdoc static-assets styles.css w/ footer styles
disabled.
- Alternate page layout controlled by jade2ng harp global
@chalin
Copy link
Contributor Author

chalin commented Oct 3, 2016

@kwalrath
Copy link
Contributor

kwalrath commented Oct 3, 2016

The results look great. Does anyone want to review the actual code, @wardbell?

@kwalrath
Copy link
Contributor

kwalrath commented Oct 3, 2016

I'm going to merge, but I need to talk with @naomiblack before deploying... That should happen within the hour.

@kwalrath kwalrath merged commit db6625e into angular:master Oct 3, 2016
@chalin chalin deleted the chalin-dart-api-fix-w-ng2-page-gen-1003 branch October 4, 2016 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dart documentation footer is floating in the middle of the page

3 participants