Skip to content

Conversation

@alan-agius4
Copy link
Collaborator

Prior to this change there was a missing check that causes the migration to remove valid config when it was executed multiple times or on configs that do not contain the deprecated option.

Closes #26063

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker labels Oct 19, 2023
@alan-agius4 alan-agius4 requested a review from clydin October 19, 2023 07:15
@alan-agius4 alan-agius4 added this to the v17 milestone Oct 19, 2023
…y executed

Prior to this change there was a missing check that causes the migration to remove valid config when it was executed multiple times or on configs that do not contain the deprecated option.

Closes angular#26063
@alan-agius4 alan-agius4 force-pushed the migration-config-noop branch from 8d253d3 to 966b4ff Compare October 19, 2023 07:18
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 19, 2023
@alan-agius4 alan-agius4 merged commit 53f93b9 into angular:main Oct 19, 2023
@alan-agius4 alan-agius4 deleted the migration-config-noop branch October 19, 2023 11:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NG17-RC0: Next8->RC0 changed angular.json

2 participants