Skip to content

Conversation

@alan-agius4
Copy link
Collaborator

Closes #21075

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 8, 2021
@alan-agius4 alan-agius4 requested a review from clydin June 8, 2021 12:00
@google-cla google-cla bot added the cla: yes label Jun 8, 2021
// Node.js 10.x does not support `createRequire` so fallback to `createRequireFromPath`
// `createRequireFromPath` is deprecated in 12+ and can be removed once 10.x support is removed
const scopedRequire = createRequire?.(schematicFile) || createRequireFromPath(schematicFile);
const { createRequire } = require('module');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This can be an import now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 8, 2021
@alan-agius4 alan-agius4 merged commit cf3b22d into angular:master Jun 8, 2021
@alan-agius4 alan-agius4 deleted the schematics branch June 8, 2021 16:29
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration failed from 11 to 12: Remove deprecated options from 'angular.json' that are no longer present in v12.

2 participants