Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented May 30, 2019

The from operator allows for the normalization of observables, obervable-like objects, and promises.

Fixes #14579

@clydin clydin force-pushed the architect-observable branch from 9572804 to 6c1ffec Compare May 30, 2019 15:58
@clydin clydin requested a review from alan-agius4 May 30, 2019 16:03
@clydin clydin added the target: major This PR is targeted for the next major release label May 30, 2019
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels May 30, 2019
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test??

@alexeagle alexeagle merged commit 19ed795 into angular:master May 30, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
@clydin clydin deleted the architect-observable branch January 9, 2020 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different versions of RxJS not supported

4 participants