fix(@angular-devkit/build-angular): live reload cannot be disabled #14301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
By default the application will be served with inline mode enabled. This means that a script will be inserted in your bundle to take care of live reloading. However at the moment we are already adding these scripts in `_addLiveReload` method. With this change we always disable this behaviour and only add it when needed via the `_addLiveReload` logic. Eventually we should try to remove the logic and rely on webpack-dev-server interals. Fixes #14300
clydin
approved these changes
Apr 29, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the application will be served with inline mode enabled. This means that a script will be inserted in your bundle to take care of live reloading.
However at the moment we are already adding these scripts in
_addLiveReloadmethod.With this change we always disable this behaviour and only add it when needed via the
_addLiveReloadlogic.Eventually we should try to remove the logic and rely on webpack-dev-server interals.
Fixes #14300