fix(@angular/cli): migrate legacy global config when present

Author: clydin

packages/@angular/cli/commands/config.ts

@@ -1,13 +1,19 @@
 import { writeFileSync } from 'fs';
 import { Command, Option } from '../models/command';
-import { getWorkspace, getWorkspaceRaw, validateWorkspace } from '../utilities/config';
+import {
+  getWorkspace,
+  getWorkspaceRaw,
+  migrateLegacyGlobalConfig,
+  validateWorkspace,
+} from '../utilities/config';
 import {
   JsonValue,
   JsonArray,
   JsonObject,
   JsonParseMode,
   experimental,
   parseJson,
+  tags,
 } from '@angular-devkit/core';
 
 const SilentError = require('silent-error');
@@ -165,10 +171,22 @@ export default class ConfigCommand extends Command {
   public run(options: ConfigOptions) {
     const level = options.global ? 'global' : 'local';
 
-    if (options.value == undefined) {
-      const config =
+    let config =
       (getWorkspace(level) as {} as { _workspace: experimental.workspace.WorkspaceSchema });
 
+    if (options.global && !config) {
+      try {
+        if (migrateLegacyGlobalConfig()) {
+          config =
+            (getWorkspace(level) as {} as { _workspace: experimental.workspace.WorkspaceSchema });
+          this.logger.info(tags.oneLine`
+            We found a global configuration that was used in Angular CLI 1.
+            It has been automatically migrated.`);
+        }
+      } catch {}
+    }
+
+    if (options.value == undefined) {
       if (!config) {
         throw new SilentError('No config found.');
       }

packages/@angular/cli/utilities/config.ts

@@ -7,8 +7,10 @@ import {
   JsonValue,
   experimental,
   normalize,
+  parseJson,
   parseJsonAst,
   virtualFs,
+  JsonObject,
 } from '@angular-devkit/core';
 import { NodeJsSyncHost } from '@angular-devkit/core/node';
 import { findUp } from './find-up';
@@ -165,6 +167,58 @@ export function getPackageManager(): string {
   return 'npm';
 }
 
+export function migrateLegacyGlobalConfig(): boolean {
+  const homeDir = os.homedir();
+  if (homeDir) {
+    const legacyGlobalConfigPath = path.join(homeDir, '.angular-cli.json');
+    if (existsSync(legacyGlobalConfigPath)) {
+      const content = readFileSync(legacyGlobalConfigPath, 'utf-8');
+      const legacy = parseJson(content, JsonParseMode.Loose);
+      if (!legacy || typeof legacy != 'object' || Array.isArray(legacy)) {
+        return false;
+      }
+
+      const cli: JsonObject = {};
+
+      if (legacy.packageManager && typeof legacy.packageManager == 'string'
+          && legacy.packageManager !== 'default') {
+        cli['packageManager'] = legacy.packageManager;
+      }
+
+      if (legacy.defaults && typeof legacy.defaults == 'object' && !Array.isArray(legacy.defaults)
+          && legacy.defaults.schematics && typeof legacy.defaults.schematics == 'object'
+          && !Array.isArray(legacy.defaults.schematics)
+          && typeof legacy.defaults.schematics.collection == 'string') {
+        cli['defaultCollection'] = legacy.defaults.schematics.collection;
+      }
+
+      if (legacy.warnings && typeof legacy.warnings == 'object'
+          && !Array.isArray(legacy.warnings)) {
+
+        let warnings: JsonObject = {};
+        if (typeof legacy.warnings.versionMismatch == 'boolean') {
+          warnings['versionMismatch'] = legacy.warnings.versionMismatch;
+        }
+        if (typeof legacy.warnings.typescriptMismatch == 'boolean') {
+          warnings['typescriptMismatch'] = legacy.warnings.typescriptMismatch;
+        }
+
+        if (Object.getOwnPropertyNames(warnings).length > 0) {
+          cli['warnings'] = warnings;
+        }
+      }
+
+      if (Object.getOwnPropertyNames(cli).length > 0) {
+        const globalPath = path.join(homeDir, globalFileName);
+        writeFileSync(globalPath, JSON.stringify({ version: 1, cli }, null, 2));
+        return true;
+      }
+    }
+  }
+
+  return false;
+}
+
 // Fallback, check for packageManager in config file in v1.* global config.
 function getLegacyPackageManager(): string | null {
   const homeDir = os.homedir();
@@ -173,14 +227,14 @@ function getLegacyPackageManager(): string | null {
     if (existsSync(legacyGlobalConfigPath)) {
       const content = readFileSync(legacyGlobalConfigPath, 'utf-8');
 
-      const ast = parseJsonAst(content, JsonParseMode.Loose);
-      if (ast.kind != 'object') {
+      const legacy = parseJson(content, JsonParseMode.Loose);
+      if (!legacy || typeof legacy != 'object' || Array.isArray(legacy)) {
         return null;
       }
-      const cfg = ast as JsonAstObject;
-      if (cfg.value.packageManager && typeof cfg.value.packageManager === 'string' &&
-          cfg.value.packageManager !== 'default') {
-        return cfg.value.packageManager;
+
+      if (legacy.packageManager && typeof legacy.packageManager === 'string'
+          && legacy.packageManager !== 'default') {
+        return legacy.packageManager;
       }
     }
   }

tests/acceptance/config.spec.ts

@@ -0,0 +1,49 @@
+import { migrateLegacyGlobalConfig } from '@angular/cli/utilities/config';
+import * as mockFs from 'mock-fs';
+import * as fs from 'fs';
+import * as os from 'os';
+import {join} from 'path';
+
+
+const homedir = os.homedir();
+describe('migrateLegacyGlobalConfig', () => {
+  let validConfig: any;
+  beforeEach(() => {
+    validConfig = {
+      packageManager: 'yarn',
+      defaults: {
+        schematics: {
+          collection: 'collection name'
+        }
+      },
+      warnings: {
+        versionMismatch: true,
+        typescriptMismatch: true
+      }
+    };
+  });
+
+  afterEach(() => {
+    mockFs.restore();
+  });
+
+  it('should return false if old config does not exist', () => {
+    mockFs({});
+    const results = migrateLegacyGlobalConfig();
+    expect(results).toEqual(false);
+  });
+
+  it('should convert values to new config file', () => {
+    mockFs({
+      [join(homedir, '.angular-cli.json')]: JSON.stringify(validConfig)
+    });
+    const results = migrateLegacyGlobalConfig();
+    expect(results).toEqual(true);
+    const content = fs.readFileSync(join(homedir, '.angular-config.json'), 'utf-8');
+    const newConfig = JSON.parse(content);
+    expect(newConfig.cli.packageManager).toEqual('yarn');
+    expect(newConfig.cli.defaultCollection).toEqual('collection name');
+    expect(newConfig.cli.warnings.versionMismatch).toEqual(true);
+    expect(newConfig.cli.warnings.typescriptMismatch).toEqual(true);
+  });
+});