Skip to content

Commit 58a39b4

Browse files
clydinclydin
committed
build: move rxjs dependency out of root
With the migration to `rules_js`, package specific dependencies now only need to be referenced with the source `package.json` for each specific package. The `rxjs` dependency has now been moved to usage locations instead of the root of the repository.
1 parent 63428f3 commit 58a39b4

File tree

22 files changed

+42
-39
lines changed

22 files changed

+42
-39
lines changed

‎modules/testing/builder/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ ts_project(
2424
deps = [
2525
":node_modules/@angular-devkit/architect",
2626
":node_modules/@angular-devkit/core",
27+
":node_modules/rxjs",
2728
"//:node_modules/@types/node",
28-
"//:node_modules/rxjs",
2929
],
3030
)
3131

‎modules/testing/builder/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"@angular-devkit/core": "workspace:*",
44
"@angular-devkit/architect": "workspace:*",
55
"@angular/ssr": "workspace:*",
6-
"@angular-devkit/build-angular": "workspace:*"
6+
"@angular-devkit/build-angular": "workspace:*",
7+
"rxjs": "7.8.2"
78
}
89
}

‎package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@
132132
"rollup": "4.36.0",
133133
"rollup-license-plugin": "~3.0.1",
134134
"rollup-plugin-sourcemaps": "^0.6.0",
135-
"rxjs": "7.8.2",
136135
"semver": "7.7.1",
137136
"shelljs": "^0.9.0",
138137
"source-map-support": "0.5.21",

‎packages/angular/build/BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ ts_project(
170170
"//:node_modules/@angular/core",
171171
"//:node_modules/@angular/platform-browser",
172172
"//:node_modules/@angular/router",
173-
"//:node_modules/rxjs",
173+
":node_modules/rxjs",
174174
"//:node_modules/tslib",
175175
"//:node_modules/typescript",
176176
"//:node_modules/zone.js",
@@ -203,7 +203,7 @@ ts_project(
203203
"//:node_modules/@angular/platform-browser",
204204
"//:node_modules/@angular/router",
205205
":node_modules/ng-packagr",
206-
"//:node_modules/rxjs",
206+
":node_modules/rxjs",
207207
"//:node_modules/tslib",
208208
"//:node_modules/typescript",
209209
"//:node_modules/zone.js",
@@ -237,7 +237,7 @@ ts_project(
237237
"//:node_modules/@angular/core",
238238
"//:node_modules/@angular/platform-browser",
239239
"//:node_modules/@angular/router",
240-
"//:node_modules/rxjs",
240+
":node_modules/rxjs",
241241
"//:node_modules/tslib",
242242
"//:node_modules/typescript",
243243
"//:node_modules/zone.js",

‎packages/angular/build/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@
5454
"@angular-devkit/core": "workspace:*",
5555
"less": "4.2.2",
5656
"ng-packagr": "20.0.0-next.1",
57-
"postcss": "8.5.3"
57+
"postcss": "8.5.3",
58+
"rxjs": "7.8.2"
5859
},
5960
"peerDependencies": {
6061
"@angular/compiler": "0.0.0-ANGULAR-FW-PEER-DEP",

‎packages/angular_devkit/architect/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ ts_project(
6969
module_name = "@angular-devkit/architect",
7070
deps = [
7171
":node_modules/@angular-devkit/core",
72+
":node_modules/rxjs",
7273
"//:node_modules/@types/node",
73-
"//:node_modules/rxjs",
7474
],
7575
)
7676

@@ -81,9 +81,9 @@ ts_project(
8181
deps = [
8282
":architect",
8383
":node_modules/@angular-devkit/core",
84+
":node_modules/rxjs",
8485
"//:node_modules/@types/jasmine",
8586
"//:node_modules/@types/node",
86-
"//:node_modules/rxjs",
8787
"//packages/angular_devkit/architect/testing",
8888
],
8989
)

‎packages/angular_devkit/architect/node/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ ts_project(
1818
module_name = "@angular-devkit/architect/node",
1919
deps = [
2020
"//:node_modules/@types/node",
21-
"//:node_modules/rxjs",
2221
"//packages/angular_devkit/architect",
2322
"//packages/angular_devkit/architect:node_modules/@angular-devkit/core",
23+
"//packages/angular_devkit/architect:node_modules/rxjs",
2424
],
2525
)
2626

@@ -36,8 +36,8 @@ ts_project(
3636
":node",
3737
"//:node_modules/@types/jasmine",
3838
"//:node_modules/@types/node",
39-
"//:node_modules/rxjs",
4039
"//packages/angular_devkit/architect",
40+
"//packages/angular_devkit/architect:node_modules/rxjs",
4141
"//packages/angular_devkit/architect/node/test:test_lib",
4242
],
4343
)

‎packages/angular_devkit/architect/testing/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ ts_project(
1818
module_name = "@angular-devkit/architect/testing",
1919
deps = [
2020
"//:node_modules/@types/node",
21-
"//:node_modules/rxjs",
2221
"//packages/angular_devkit/architect",
2322
"//packages/angular_devkit/architect:node_modules/@angular-devkit/core",
23+
"//packages/angular_devkit/architect:node_modules/rxjs",
2424
],
2525
)

‎packages/angular_devkit/build_angular/BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ ts_project(
169169
":node_modules/postcss",
170170
":node_modules/postcss-loader",
171171
":node_modules/resolve-url-loader",
172+
":node_modules/rxjs",
172173
":node_modules/sass",
173174
":node_modules/sass-loader",
174175
":node_modules/source-map-loader",
@@ -201,7 +202,6 @@ ts_project(
201202
"//:node_modules/fast-glob",
202203
"//:node_modules/karma",
203204
"//:node_modules/karma-source-map-support",
204-
"//:node_modules/rxjs",
205205
"//:node_modules/semver",
206206
"//:node_modules/tslib",
207207
"//:node_modules/typescript",
@@ -299,9 +299,9 @@ ts_project(
299299
":node_modules/@angular-devkit/architect",
300300
":node_modules/@angular-devkit/core",
301301
":node_modules/@angular/build",
302+
":node_modules/rxjs",
302303
"//:node_modules/@types/jasmine",
303304
"//:node_modules/@types/node",
304-
"//:node_modules/rxjs",
305305
"//modules/testing/builder",
306306
],
307307
)
@@ -403,7 +403,7 @@ LARGE_SPECS = {
403403
"//:node_modules/@angular/core",
404404
"//:node_modules/@angular/platform-browser",
405405
"//:node_modules/@angular/router",
406-
"//:node_modules/rxjs",
406+
":node_modules/rxjs",
407407
"//:node_modules/tslib",
408408
"//:node_modules/typescript",
409409
"//:node_modules/zone.js",

‎packages/angular_devkit/build_angular/src/builders/browser/specs/lazy-module_spec.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -149,15 +149,10 @@ describe('Browser Builder lazy modules', () => {
149149
'src/main.ts': `import('./one'); import('./two');`,
150150
});
151151

152-
const { files } = await browserBuild(architect, host, target, {
153-
// Preserve symlinks to reliably verify the chunk names. When symlinks
154-
// would be dereferenced, the `@angular/common` file can originate from a
155-
// less predictable path in e.g. node_modules/.pnpm/<...>`.
156-
preserveSymlinks: true,
157-
});
152+
const { files } = await browserBuild(architect, host, target);
158153
expect(files['src_one_ts.js']).toBeDefined();
159154
expect(files['src_two_ts.js']).toBeDefined();
160-
expect(files['default-node_modules_angular_common_fesm2022_http_mjs.js']).toBeDefined();
155+
expect(Object.keys(files)).toContain(jasmine.stringContaining('_angular_common_'));
161156
});
162157

163158
it(`supports disabling the common bundle`, async () => {

0 commit comments

Comments
 (0)