fix(State): do not return duplicate Param objs for url params in State.parameters()

Author: christopherthielen

src/state/hooks/transitionManager.ts

@@ -89,7 +89,8 @@ export default class TransitionManager {
     if (error instanceof TransitionRejection) {
       if (error.type === RejectType.IGNORED) {
         // Update $stateParmas/$state.params/$location.url if transition ignored, but dynamic params have changed.
-        if (!Param.equals($state.$current.parameters().filter(prop('dynamic')), $stateParams, transition.params())) {
+        let dynamic = $state.$current.parameters().filter(prop('dynamic'));
+        if (!Param.equals(dynamic, $stateParams, transition.params())) {
           this.updateStateParams();
         }
         return $state.current;

src/state/state.ts

@@ -114,12 +114,10 @@ export class State {
     return this.parent && this.parent.root() || this;
   }
 
-  parameters(opts: any = {}): Param[] {
+  parameters(opts?): Param[] {
     opts = defaults(opts, { inherit: true });
-
-    return (this.parent && opts.inherit && this.parent.parameters() || [])
-      .concat(this.url && this.url.parameters({ inherit: false }) || [])
-      .concat(values(this.params));
+    var inherited = opts.inherit && this.parent && this.parent.parameters() || [];
+    return inherited.concat(values(this.params));
   }
 
   parameter(id: string, opts: any = {}): Param {