Fix getSymbolAtLocation for importCall (microsoft#1587)

Author: sheetalkamat

internal/checker/checker.go

@@ -30272,7 +30272,7 @@ func (c *Checker) getSymbolAtLocation(node *ast.Node, ignoreErrors bool) *ast.Sy
 		// 4). type A = import("./f/*gotToDefinitionHere*/oo")
 		if (ast.IsExternalModuleImportEqualsDeclaration(grandParent) && ast.GetExternalModuleImportEqualsDeclarationExpression(grandParent) == node) ||
 			((parent.Kind == ast.KindImportDeclaration || parent.Kind == ast.KindJSImportDeclaration || parent.Kind == ast.KindExportDeclaration) && ast.GetExternalModuleName(parent) == node) ||
-			ast.IsVariableDeclarationInitializedToRequire(grandParent) ||
+			ast.IsVariableDeclarationInitializedToRequire(grandParent) || ast.IsImportCall(parent) ||
 			(ast.IsLiteralTypeNode(parent) && ast.IsLiteralImportTypeNode(grandParent) && grandParent.AsImportTypeNode().Argument == parent) {
 			return c.resolveExternalModuleName(node, node, ignoreErrors)
 		}

internal/fourslash/_scripts/failingTests.txt

@@ -168,6 +168,7 @@ TestDoubleUnderscoreCompletions
 TestEditJsdocType
 TestExportDefaultClass
 TestExportDefaultFunction
+TestFindAllReferencesDynamicImport1
 TestFindAllReferencesTripleSlash
 TestFindAllReferencesUmdModuleAsGlobalConst
 TestFindAllRefsCommonJsRequire

internal/fourslash/tests/gen/findAllReferencesDynamicImport1_test.go

@@ -9,7 +9,7 @@ import (
 
 func TestFindAllReferencesDynamicImport1(t *testing.T) {
 	t.Parallel()
-
+	t.Skip()
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @Filename: foo.ts
 export function foo() { return "foo"; }

testdata/baselines/reference/fourslash/findAllRef/FindAllReferencesDynamicImport1.baseline.jsonc

@@ -1,16 +1,16 @@
 // === goToDefinition ===
 // === /foo.ts ===
 
-// export function foo() { return "foo"; }
+// [|export function foo() { return "foo"; }
 // import("./f/*GO TO DEFINITION*/oo")
-// var x = import("./foo")
+// var x = import("./foo")|]
 
 
 
 
 // === goToDefinition ===
 // === /foo.ts ===
 
-// export function foo() { return "foo"; }
+// [|export function foo() { return "foo"; }
 // import("./foo")
-// var x = import("./fo/*GO TO DEFINITION*/o")
+// var x = import("./fo/*GO TO DEFINITION*/o")|]

testdata/baselines/reference/fourslash/goToDef/GoToDefinitionDynamicImport1.baseline.jsonc

@@ -8,6 +8,7 @@ export function a() {}
 export const x = add(import("./sub"));
 >x : Symbol(x, Decl(index.ts, 0, 12))
 >add : Symbol(add, Decl(index.ts, 1, 27))
+>"./sub" : Symbol("sub", Decl(sub.ts, 0, 0))
 
 export * as Q from "./sub";
 >Q : Symbol(Q, Decl(index.ts, 1, 6))

testdata/baselines/reference/submodule/compiler/declarationEmitDoesNotUseReexportedNamespaceAsLocal.symbols

@@ -28,6 +28,7 @@ export default (suit: Suit, rank: Rank) => ({suit, rank});
 export let lazyCard = () => import('./Card').then(a => a.default);
 >lazyCard : Symbol(lazyCard, Decl(index.ts, 0, 10))
 >import('./Card').then : Symbol(then, Decl(lib.es5.d.ts, --, --))
+>'./Card' : Symbol("Card", Decl(Card.ts, 0, 0))
 >then : Symbol(then, Decl(lib.es5.d.ts, --, --))
 >a : Symbol(a, Decl(index.ts, 0, 50))
 >a.default : Symbol(default, Decl(Card.ts, 0, 37))

testdata/baselines/reference/submodule/compiler/declarationEmitDoesNotUseReexportedNamespaceAsLocal.symbols.diff

@@ -5,9 +5,9 @@
  export let lazyCard = () => import('./Card').then(a => a.default);
  >lazyCard : Symbol(lazyCard, Decl(index.ts, 0, 10))
 ->import('./Card').then : Symbol(Promise.then, Decl(lib.es5.d.ts, --, --))
-->'./Card' : Symbol("Card", Decl(Card.ts, 0, 0))
-->then : Symbol(Promise.then, Decl(lib.es5.d.ts, --, --))
 +>import('./Card').then : Symbol(then, Decl(lib.es5.d.ts, --, --))
+ >'./Card' : Symbol("Card", Decl(Card.ts, 0, 0))
+->then : Symbol(Promise.then, Decl(lib.es5.d.ts, --, --))
 +>then : Symbol(then, Decl(lib.es5.d.ts, --, --))
  >a : Symbol(a, Decl(index.ts, 0, 50))
  >a.default : Symbol(default, Decl(Card.ts, 0, 37))

testdata/baselines/reference/submodule/compiler/declarationEmitExportAliasVisibiilityMarking.symbols

@@ -24,9 +24,14 @@ export const mod = await (async () => {
 
     case 0:
       return await import("./case0.js");
+>"./case0.js" : Symbol("/case0", Decl(case0.ts, 0, 0))
+
     case 1:
       return await import("./case1.js");
+>"./case1.js" : Symbol("/case1", Decl(case1.ts, 0, 0))
+
     default:
       return await import("./caseFallback.js");
+>"./caseFallback.js" : Symbol("/caseFallback", Decl(caseFallback.ts, 0, 0))
   }
 })();