Skip to content

Commit a94d7e2

Browse files
avijayanhwxahussein
authored andcommitted
HDDS-1832 : Improve logging for PipelineActions handling in SCM and datanode. (apache#1200)
1 parent 3da8110 commit a94d7e2

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ private void triggerPipelineClose(RaftGroupId groupId, String detail,
558558
if (triggerHB) {
559559
context.getParent().triggerHeartbeat();
560560
}
561-
LOG.debug(
561+
LOG.info(
562562
"pipeline Action " + action.getAction() + " on pipeline " + pipelineID
563563
+ ".Reason : " + action.getClosePipeline().getDetailedReason());
564564
}

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineActionHandler.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,10 @@ public void onMessage(PipelineActionsFromDatanode report,
5757
pipelineID = PipelineID.
5858
getFromProtobuf(action.getClosePipeline().getPipelineID());
5959
Pipeline pipeline = pipelineManager.getPipeline(pipelineID);
60-
LOG.info("Received pipeline action {} for {} from datanode {}",
61-
action.getAction(), pipeline, report.getDatanodeDetails());
62-
pipelineManager.finalizeAndDestroyPipeline(pipeline, true);
60+
LOG.info("Received pipeline action {} for {} from datanode {}. " +
61+
"Reason : {}", action.getAction(), pipeline,
62+
report.getDatanodeDetails(),
63+
action.getClosePipeline().getDetailedReason());
6364
} catch (IOException ioe) {
6465
LOG.error("Could not execute pipeline action={} pipeline={} {}",
6566
action, pipelineID, ioe);

0 commit comments

Comments
 (0)