Skip to content

Commit fe94793

Browse files
Yunlei HeJaegeuk Kim
authored andcommitted
f2fs: get victim segment again after new cp
Previous selected segment may become free after write_checkpoint, if we do garbage collect on this segment, and then new_curseg happen to reuse it, it may cause f2fs_bug_on as below. panic+0x154/0x29c do_garbage_collect+0x15c/0xaf4 f2fs_gc+0x2dc/0x444 f2fs_balance_fs.part.22+0xcc/0x14c f2fs_balance_fs+0x28/0x34 f2fs_map_blocks+0x5ec/0x790 f2fs_preallocate_blocks+0xe0/0x100 f2fs_file_write_iter+0x64/0x11c new_sync_write+0xac/0x11c vfs_write+0x144/0x1e4 SyS_write+0x60/0xc0 Here, maybe we check sit and ssa type during reset_curseg. So, we check segment is stale or not, and select a new victim to avoid this. Signed-off-by: Yunlei He <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent 6f3ec99 commit fe94793

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

fs/f2fs/gc.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -908,10 +908,13 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync)
908908
* enough free sections, we should flush dent/node blocks and do
909909
* garbage collections.
910910
*/
911-
if (__get_victim(sbi, &segno, gc_type) || prefree_segments(sbi))
911+
if (__get_victim(sbi, &segno, gc_type) ||
912+
prefree_segments(sbi)) {
912913
write_checkpoint(sbi, &cpc);
913-
else if (has_not_enough_free_secs(sbi, 0))
914+
segno = NULL_SEGNO;
915+
} else if (has_not_enough_free_secs(sbi, 0)) {
914916
write_checkpoint(sbi, &cpc);
917+
}
915918
}
916919

917920
if (segno == NULL_SEGNO && !__get_victim(sbi, &segno, gc_type))

0 commit comments

Comments
 (0)