Skip to content

Commit fcacafd

Browse files
author
Al Viro
committed
kill the 5th argument of generic_file_buffered_write()
same story - it's &iocb->ki_pos in all cases Signed-off-by: Al Viro <[email protected]>
1 parent 41fc56d commit fcacafd

File tree

5 files changed

+8
-10
lines changed

5 files changed

+8
-10
lines changed

fs/ceph/file.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -978,8 +978,7 @@ static ssize_t ceph_aio_write(struct kiocb *iocb, const struct iovec *iov,
978978
* can not run at the same time
979979
*/
980980
written = generic_file_buffered_write(iocb, iov, nr_segs,
981-
pos, &iocb->ki_pos,
982-
count, 0);
981+
pos, count, 0);
983982
mutex_unlock(&inode->i_mutex);
984983
}
985984

fs/ocfs2/file.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2383,7 +2383,7 @@ static ssize_t ocfs2_file_aio_write(struct kiocb *iocb,
23832383
} else {
23842384
current->backing_dev_info = file->f_mapping->backing_dev_info;
23852385
written = generic_file_buffered_write(iocb, iov, nr_segs, *ppos,
2386-
ppos, count, 0);
2386+
count, 0);
23872387
current->backing_dev_info = NULL;
23882388
}
23892389

fs/xfs/xfs_file.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,7 @@ xfs_file_buffered_aio_write(
738738
write_retry:
739739
trace_xfs_file_buffered_write(ip, count, iocb->ki_pos, 0);
740740
ret = generic_file_buffered_write(iocb, iovp, nr_segs,
741-
pos, &iocb->ki_pos, count, 0);
741+
pos, count, 0);
742742

743743
/*
744744
* If we just got an ENOSPC, try to write back all dirty inodes to

include/linux/fs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2397,7 +2397,7 @@ extern ssize_t generic_file_aio_write(struct kiocb *, const struct iovec *, unsi
23972397
extern ssize_t generic_file_direct_write(struct kiocb *, const struct iovec *,
23982398
unsigned long *, loff_t, loff_t *, size_t, size_t);
23992399
extern ssize_t generic_file_buffered_write(struct kiocb *, const struct iovec *,
2400-
unsigned long, loff_t, loff_t *, size_t, ssize_t);
2400+
unsigned long, loff_t, size_t, ssize_t);
24012401
extern ssize_t do_sync_read(struct file *filp, char __user *buf, size_t len, loff_t *ppos);
24022402
extern ssize_t do_sync_write(struct file *filp, const char __user *buf, size_t len, loff_t *ppos);
24032403
extern int generic_segment_checks(const struct iovec *iov,

mm/filemap.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2183,7 +2183,7 @@ static ssize_t generic_perform_write(struct file *file,
21832183

21842184
ssize_t
21852185
generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov,
2186-
unsigned long nr_segs, loff_t pos, loff_t *ppos,
2186+
unsigned long nr_segs, loff_t pos,
21872187
size_t count, ssize_t written)
21882188
{
21892189
struct file *file = iocb->ki_filp;
@@ -2195,7 +2195,7 @@ generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov,
21952195

21962196
if (likely(status >= 0)) {
21972197
written += status;
2198-
*ppos = pos + status;
2198+
iocb->ki_pos = pos + status;
21992199
}
22002200

22012201
return written ? written : status;
@@ -2275,8 +2275,7 @@ ssize_t __generic_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
22752275
pos += written;
22762276
count -= written;
22772277
written_buffered = generic_file_buffered_write(iocb, iov,
2278-
nr_segs, pos, &iocb->ki_pos, count,
2279-
written);
2278+
nr_segs, pos, count, written);
22802279
/*
22812280
* If generic_file_buffered_write() retuned a synchronous error
22822281
* then we want to return the number of bytes which were
@@ -2309,7 +2308,7 @@ ssize_t __generic_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
23092308
}
23102309
} else {
23112310
written = generic_file_buffered_write(iocb, iov, nr_segs,
2312-
pos, &iocb->ki_pos, count, written);
2311+
pos, count, written);
23132312
}
23142313
out:
23152314
current->backing_dev_info = NULL;

0 commit comments

Comments
 (0)