Input: evdev - fix EVIOCSABS regression

zonque · dtor · commit f9ce6eb5b6fa · 2010-10-18T08:45:08.000-07:00
448cd16 ("Input: evdev - rearrange ioctl handling") broke EVIOCSABS by checking for the wrong direction bit. Signed-off-by: Daniel Mack <zonque@gmail.com> Reported-by: Sven Neumann <s.neumann@raumfeld.com> Tested-by: Sven Neumann <s.neumann@raumfeld.com> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
@@ -683,7 +683,7 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd,
 		}
 	}
 
-	if (_IOC_DIR(cmd) == _IOC_READ) {
+	if (_IOC_DIR(cmd) == _IOC_WRITE) {
 
 		if ((_IOC_NR(cmd) & ~ABS_MAX) == _IOC_NR(EVIOCSABS(0))) {
 

Original file line number	Diff line number	Diff line change
`@@ -683,7 +683,7 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd,`
`683`	`683`	`}`
`684`	`684`	`}`
`685`	`685`
`686`		`- if (_IOC_DIR(cmd) == _IOC_READ) {`
	`686`	`+ if (_IOC_DIR(cmd) == _IOC_WRITE) {`
`687`	`687`
`688`	`688`	`if ((_IOC_NR(cmd) & ~ABS_MAX) == _IOC_NR(EVIOCSABS(0))) {`
`689`	`689`