rocker: fix an error code

Dan Carpenter · davem330 · commit f73e0c24bf07 · 2016-02-27T14:06:14.000-05:00
We intended to return PTR_ERR() here instead of 1. Fixes: 1f9993f ('rocker: fix a neigh entry leak issue') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c
@@ -1449,7 +1449,7 @@ static int ofdpa_port_ipv4_resolve(struct ofdpa_port *ofdpa_port,
 	if (!n) {
 		n = neigh_create(&arp_tbl, &ip_addr, dev);
 		if (IS_ERR(n))
-			return IS_ERR(n);
+			return PTR_ERR(n);
 	}
 
 	/* If the neigh is already resolved, then go ahead and

Original file line number	Diff line number	Diff line change
`@@ -1449,7 +1449,7 @@ static int ofdpa_port_ipv4_resolve(struct ofdpa_port *ofdpa_port,`
`1449`	`1449`	`if (!n) {`
`1450`	`1450`	`n = neigh_create(&arp_tbl, &ip_addr, dev);`
`1451`	`1451`	`if (IS_ERR(n))`
`1452`		`- return IS_ERR(n);`
	`1452`	`+ return PTR_ERR(n);`
`1453`	`1453`	`}`
`1454`	`1454`
`1455`	`1455`	`/* If the neigh is already resolved, then go ahead and`