tg3: Remove unnecessary lock around tg3_flag_set

Nithin Sujir · davem330 · commit f2068b80ca59 · 2013-05-24T22:23:30.000-07:00
The spinlock was needed when flags used to be a u32 and set/cleared
using bit operations. Now that we use the atomic set_bit, this lock
isn't needed.

Signed-off-by: Nithin Nayak Sujir &lt;nsujir@broadcom.com&gt;
Signed-off-by: Michael Chan &lt;mchan@broadcom.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
@@ -6386,9 +6386,7 @@ static void tg3_tx_recover(struct tg3 *tp)
 		    "Please report the problem to the driver maintainer "
 		    "and include system chipset information.\n");
 
-	spin_lock(&tp->lock);
 	tg3_flag_set(tp, TX_RECOVERY_PENDING);
-	spin_unlock(&tp->lock);
 }
 
 static inline u32 tg3_tx_avail(struct tg3_napi *tnapi)

Original file line number	Diff line number	Diff line change
`@@ -6386,9 +6386,7 @@ static void tg3_tx_recover(struct tg3 *tp)`
`6386`	`6386`	`"Please report the problem to the driver maintainer "`
`6387`	`6387`	`"and include system chipset information.\n");`
`6388`	`6388`
`6389`		`- spin_lock(&tp->lock);`
`6390`	`6389`	`tg3_flag_set(tp, TX_RECOVERY_PENDING);`
`6391`		`- spin_unlock(&tp->lock);`
`6392`	`6390`	`}`
`6393`	`6391`
`6394`	`6392`	`static inline u32 tg3_tx_avail(struct tg3_napi *tnapi)`