Skip to content

Commit f185a49

Browse files
tlfalcondavem330
authored andcommitted
ibmvnic: Deactivate RX pool buffer replenishment on H_CLOSED
If H_CLOSED is returned, halt RX buffer replenishment activity until firmware sends a notification that the driver can reset. Signed-off-by: Thomas Falcon <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b8c80b8 commit f185a49

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

drivers/net/ethernet/ibm/ibmvnic.c

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,15 @@ static void free_long_term_buff(struct ibmvnic_adapter *adapter,
200200
dma_free_coherent(dev, ltb->size, ltb->buff, ltb->addr);
201201
}
202202

203+
static void deactivate_rx_pools(struct ibmvnic_adapter *adapter)
204+
{
205+
int i;
206+
207+
for (i = 0; i < be32_to_cpu(adapter->login_rsp_buf->num_rxadd_subcrqs);
208+
i++)
209+
adapter->rx_pool[i].active = 0;
210+
}
211+
203212
static void replenish_rx_pool(struct ibmvnic_adapter *adapter,
204213
struct ibmvnic_rx_pool *pool)
205214
{
@@ -217,6 +226,9 @@ static void replenish_rx_pool(struct ibmvnic_adapter *adapter,
217226
int index;
218227
int i;
219228

229+
if (!pool->active)
230+
return;
231+
220232
handle_array = (u64 *)((u8 *)(adapter->login_rsp_buf) +
221233
be32_to_cpu(adapter->login_rsp_buf->
222234
off_rxadd_subcrqs));
@@ -287,6 +299,15 @@ static void replenish_rx_pool(struct ibmvnic_adapter *adapter,
287299
dev_kfree_skb_any(skb);
288300
adapter->replenish_add_buff_failure++;
289301
atomic_add(buffers_added, &pool->available);
302+
303+
if (lpar_rc == H_CLOSED) {
304+
/* Disable buffer pool replenishment and report carrier off if
305+
* queue is closed. Firmware guarantees that a signal will
306+
* be sent to the driver, triggering a reset.
307+
*/
308+
deactivate_rx_pools(adapter);
309+
netif_carrier_off(adapter->netdev);
310+
}
290311
}
291312

292313
static void replenish_pools(struct ibmvnic_adapter *adapter)

0 commit comments

Comments
 (0)