Skip to content

Commit eab8723

Browse files
author
Al Viro
committed
ceph_sync_{,direct_}write: fix an oops on ceph_osdc_new_request() failure
ceph_osdc_put_request(ERR_PTR(-error)) oopses. What we want there is break, not goto out. Signed-off-by: Al Viro <[email protected]>
1 parent ccad236 commit eab8723

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

fs/ceph/file.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ ceph_sync_direct_write(struct kiocb *iocb, const struct iovec *iov,
600600
false);
601601
if (IS_ERR(req)) {
602602
ret = PTR_ERR(req);
603-
goto out;
603+
break;
604604
}
605605

606606
num_pages = calc_pages_for(page_align, len);
@@ -718,7 +718,7 @@ static ssize_t ceph_sync_write(struct kiocb *iocb, const struct iovec *iov,
718718
false);
719719
if (IS_ERR(req)) {
720720
ret = PTR_ERR(req);
721-
goto out;
721+
break;
722722
}
723723

724724
/*

0 commit comments

Comments
 (0)