tty: cyclades: TIOCSERGETLSR should should store to a uint

Dan Carpenter · gregkh · commit dbca36eab48e · 2012-03-08T11:02:51.000-08:00
TIOCSERGETLSR should be saved in a uint so the cast here to unsigned
long is a bug.

Reported-by: Jiri Slaby &lt;jslaby@suse.cz&gt;
Signed-off-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Acked-by: Jiri Slaby &lt;jslaby@suse.cz&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
@@ -2413,7 +2413,7 @@ static int get_lsr_info(struct cyclades_port *info, unsigned int __user *value)
 		/* Not supported yet */
 		return -EINVAL;
 	}
-	return put_user(result, (unsigned long __user *)value);
+	return put_user(result, value);
 }
 
 static int cy_tiocmget(struct tty_struct *tty)

Original file line number	Diff line number	Diff line change
`@@ -2413,7 +2413,7 @@ static int get_lsr_info(struct cyclades_port info, unsigned int __user value)`
`2413`	`2413`	`/* Not supported yet */`
`2414`	`2414`	`return -EINVAL;`
`2415`	`2415`	`}`
`2416`		`- return put_user(result, (unsigned long __user *)value);`
	`2416`	`+ return put_user(result, value);`
`2417`	`2417`	`}`
`2418`	`2418`
`2419`	`2419`	`static int cy_tiocmget(struct tty_struct *tty)`