Skip to content

Commit da6ccaa

Browse files
Dan StreetmanMarkus Pargmann
authored andcommitted
nbd: ratelimit error msgs after socket close
Make the "Attempted send on closed socket" error messages generated in nbd_request_handler() ratelimited. When the nbd socket is shutdown, the nbd_request_handler() function emits an error message for every request remaining in its queue. If the queue is large, this will spam a large amount of messages to the log. There's no need for a separate error message for each request, so this patch ratelimits it. In the specific case this was found, the system was virtual and the error messages were logged to the serial port, which overwhelmed it. Fixes: 4d48a54 ("nbd: fix I/O hang on disconnected nbds") Signed-off-by: Dan Streetman <[email protected]> Signed-off-by: Markus Pargmann <[email protected]>
1 parent d02cf53 commit da6ccaa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/block/nbd.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -580,8 +580,8 @@ static void nbd_request_handler(struct request_queue *q)
580580
req, req->cmd_type);
581581

582582
if (unlikely(!nbd->sock)) {
583-
dev_err(disk_to_dev(nbd->disk),
584-
"Attempted send on closed socket\n");
583+
dev_err_ratelimited(disk_to_dev(nbd->disk),
584+
"Attempted send on closed socket\n");
585585
req->errors++;
586586
nbd_end_request(nbd, req);
587587
spin_lock_irq(q->queue_lock);

0 commit comments

Comments
 (0)