Skip to content

Commit da10a20

Browse files
Anton VorontsovJeff Garzik
authored andcommitted
ahci_platform: Remove unneeded ahci_driver.probe assignment
The driver is using platform_driver_probe() during initialization, so ahci_driver.probe hook is never used. But it causes the following (harmless, luckily) section mismatch: WARNING: vmlinux.o(.data+0x2fb20): Section mismatch in reference from the variable ahci_driver to the function .init.text:ahci_probe() This patch removes the ahci_driver.probe assignment, thus fixes the warning. p.s. Note that there's another patch[1] from Rene Bolldorf that tried to solve the same issue by __refdata annotation. __refdata says that this reference is actually OK, but in fact it is not OK, because dereferencing .probe() will cause problems. So the proper fix is to remove the assignment. [1] http://kerneltrap.org/mailarchive/linux-kernel/2010/3/18/4549547 Signed-off-by: Anton Vorontsov <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
1 parent 0835480 commit da10a20

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/ata/ahci_platform.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ static int __devexit ahci_remove(struct platform_device *pdev)
171171
}
172172

173173
static struct platform_driver ahci_driver = {
174-
.probe = ahci_probe,
175174
.remove = __devexit_p(ahci_remove),
176175
.driver = {
177176
.name = "ahci",

0 commit comments

Comments
 (0)